Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-05 Thread Viresh Kumar
On 02-08-19, 11:11, Rafael J. Wysocki wrote: > On Friday, August 2, 2019 5:48:19 AM CEST Viresh Kumar wrote: > > On 01-08-19, 10:57, Doug Smythies wrote: > > > Disagree. > > > All I did was use a flag where it used to be set to UNIT_MAX, to basically > > > implement the same thing. > > > > And

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-02 Thread Rafael J. Wysocki
On Fri, Aug 2, 2019 at 11:11 AM Rafael J. Wysocki wrote: > > On Friday, August 2, 2019 5:48:19 AM CEST Viresh Kumar wrote: > > On 01-08-19, 10:57, Doug Smythies wrote: > > > On 2019.07.31 23:17 Viresh Kumar wrote: > > > > On 31-07-19, 17:20, Doug Smythies wrote: > > > >> Summary: > > > >> > > >

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-02 Thread Rafael J. Wysocki
On Friday, August 2, 2019 5:48:19 AM CEST Viresh Kumar wrote: > On 01-08-19, 10:57, Doug Smythies wrote: > > On 2019.07.31 23:17 Viresh Kumar wrote: > > > On 31-07-19, 17:20, Doug Smythies wrote: > > >> Summary: > > >> > > >> The old way, using UINT_MAX had two purposes: first, > > >> as a "need

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-01 Thread Viresh Kumar
On 01-08-19, 10:57, Doug Smythies wrote: > On 2019.07.31 23:17 Viresh Kumar wrote: > > On 31-07-19, 17:20, Doug Smythies wrote: > >> Summary: > >> > >> The old way, using UINT_MAX had two purposes: first, > >> as a "need to do a frequency update" flag; but also second, to > >> force any

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-01 Thread Doug Smythies
On 2019.07.31 23:17 Viresh Kumar wrote: > On 31-07-19, 17:20, Doug Smythies wrote: >> Summary: >> >> The old way, using UINT_MAX had two purposes: first, >> as a "need to do a frequency update" flag; but also second, to >> force any subsequent old/new frequency comparison to NOT be "the same, >>

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-01 Thread Viresh Kumar
On 01-08-19, 09:47, Rafael J. Wysocki wrote: > On Thu, Aug 1, 2019 at 8:17 AM Viresh Kumar wrote: > > > > On 31-07-19, 17:20, Doug Smythies wrote: > > > Hi Viresh, > > > > > > Summary: > > > > > > The old way, using UINT_MAX had two purposes: first, > > > as a "need to do a frequency update"

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-01 Thread Rafael J. Wysocki
On Thu, Aug 1, 2019 at 8:17 AM Viresh Kumar wrote: > > On 31-07-19, 17:20, Doug Smythies wrote: > > Hi Viresh, > > > > Summary: > > > > The old way, using UINT_MAX had two purposes: first, > > as a "need to do a frequency update" flag; but also second, to > > force any subsequent old/new

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-01 Thread Viresh Kumar
On 31-07-19, 17:20, Doug Smythies wrote: > Hi Viresh, > > Summary: > > The old way, using UINT_MAX had two purposes: first, > as a "need to do a frequency update" flag; but also second, to > force any subsequent old/new frequency comparison to NOT be "the same, > so why bother actually updating"

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-31 Thread Doug Smythies
Hi Viresh, Summary: The old way, using UINT_MAX had two purposes: first, as a "need to do a frequency update" flag; but also second, to force any subsequent old/new frequency comparison to NOT be "the same, so why bother actually updating" (see: sugov_update_next_freq). All patches so far have

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-31 Thread Doug Smythies
On 2019.07.31 Viresh Kumar wrote: > To avoid reducing the frequency of a CPU prematurely, we skip reducing > the frequency if the CPU had been busy recently. > > This should not be done when the limits of the policy are changed, for > example due to thermal throttling. We should always get the

[PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-30 Thread Viresh Kumar
To avoid reducing the frequency of a CPU prematurely, we skip reducing the frequency if the CPU had been busy recently. This should not be done when the limits of the policy are changed, for example due to thermal throttling. We should always get the frequency within the new limits as soon as

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-29 Thread Rafael J. Wysocki
On Mon, Jul 29, 2019 at 10:32 AM Viresh Kumar wrote: > > On 29-07-19, 00:55, Doug Smythies wrote: > > On 2019.07.25 23:58 Viresh Kumar wrote: > > > Hmm, so I tried to reproduce your setup on my ARM board. > > > - booted only with CPU0 so I hit the sugov_update_single() routine > > > - And applied

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-29 Thread Viresh Kumar
On 29-07-19, 00:55, Doug Smythies wrote: > On 2019.07.25 23:58 Viresh Kumar wrote: > > Hmm, so I tried to reproduce your setup on my ARM board. > > - booted only with CPU0 so I hit the sugov_update_single() routine > > - And applied below diff to make CPU look permanently busy: > > > >

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-29 Thread Doug Smythies
On 2019.07.25 23:58 Viresh Kumar wrote: > On 25-07-19, 08:20, Doug Smythies wrote: >> I tried the patch ("patch2"). It did not fix the issue. >> >> To summarize, all kernel 5.2 based, all intel_cpufreq driver and schedutil >> governor: >> >> Test: Does a busy system respond to maximum CPU clock

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-26 Thread Viresh Kumar
On 25-07-19, 08:20, Doug Smythies wrote: > I tried the patch ("patch2"). It did not fix the issue. > > To summarize, all kernel 5.2 based, all intel_cpufreq driver and schedutil > governor: > > Test: Does a busy system respond to maximum CPU clock frequency reduction? > > stock, unaltered: No.

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-25 Thread Viresh Kumar
On 25-07-19, 08:20, Doug Smythies wrote: > I tried the patch ("patch2"). It did not fix the issue. > > To summarize, all kernel 5.2 based, all intel_cpufreq driver and schedutil > governor: > > Test: Does a busy system respond to maximum CPU clock frequency reduction? > > stock, unaltered: No.

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-25 Thread Doug Smythies
Hi, I am having trouble keeping up. Here is what I have so far: On 2019.07.24 04:43 Viresh Kumar wrote: > On 23-07-19, 12:27, Rafael J. Wysocki wrote: >> On Tue, Jul 23, 2019 at 11:15 AM Viresh Kumar >> wrote: >>> Though there is one difference between intel_cpufreq and acpi_cpufreq, >>>

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-24 Thread Viresh Kumar
On 23-07-19, 12:27, Rafael J. Wysocki wrote: > On Tue, Jul 23, 2019 at 11:15 AM Viresh Kumar wrote: > > Though there is one difference between intel_cpufreq and acpi_cpufreq, > > intel_cpufreq has fast_switch_possible=true and so it uses slightly > > different path in schedutil. I tried to look

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-23 Thread Rafael J. Wysocki
On Tue, Jul 23, 2019 at 11:15 AM Viresh Kumar wrote: > > On 23-07-19, 00:10, Doug Smythies wrote: > > On 2019.07.21 23:52 Viresh Kumar wrote: > > > > > To avoid reducing the frequency of a CPU prematurely, we skip reducing > > > the frequency if the CPU had been busy recently. > > > > > > This

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-23 Thread Viresh Kumar
On 23-07-19, 00:10, Doug Smythies wrote: > On 2019.07.21 23:52 Viresh Kumar wrote: > > > To avoid reducing the frequency of a CPU prematurely, we skip reducing > > the frequency if the CPU had been busy recently. > > > > This should not be done when the limits of the policy are changed, for > >

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-23 Thread Rafael J. Wysocki
On Tue, Jul 23, 2019 at 9:10 AM Doug Smythies wrote: > > On 2019.07.21 23:52 Viresh Kumar wrote: > > > To avoid reducing the frequency of a CPU prematurely, we skip reducing > > the frequency if the CPU had been busy recently. > > > > This should not be done when the limits of the policy are

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-23 Thread Doug Smythies
On 2019.07.21 23:52 Viresh Kumar wrote: > To avoid reducing the frequency of a CPU prematurely, we skip reducing > the frequency if the CPU had been busy recently. > > This should not be done when the limits of the policy are changed, for > example due to thermal throttling. We should always get

[PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-22 Thread Viresh Kumar
To avoid reducing the frequency of a CPU prematurely, we skip reducing the frequency if the CPU had been busy recently. This should not be done when the limits of the policy are changed, for example due to thermal throttling. We should always get the frequency within limits as soon as possible.