Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-14 Thread Yue Hu
On Mon, 15 Feb 2021 12:00:08 +0530 Viresh Kumar wrote: > On 14-02-21, 11:44, Yue Hu wrote: > > On Fri, 12 Feb 2021 17:14:03 +0100 > > "Rafael J. Wysocki" wrote: > > > This may be running in parallel with sugov_update_next_freq() on a > > > different CPU, so the latter may clear

Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-14 Thread Viresh Kumar
On 14-02-21, 11:44, Yue Hu wrote: > On Fri, 12 Feb 2021 17:14:03 +0100 > "Rafael J. Wysocki" wrote: > > This may be running in parallel with sugov_update_next_freq() on a > > different CPU, so the latter may clear need_freq_update right after it > > has been set here unless I'm overlooking

Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-13 Thread Yue Hu
On Fri, 12 Feb 2021 17:14:03 +0100 "Rafael J. Wysocki" wrote: > On Mon, Feb 8, 2021 at 4:08 AM Yue Hu wrote: > > > > From: Yue Hu > > > > The limits_changed flag was introduced by commit 600f5badb78c > > ("cpufreq: schedutil: Don't skip freq update when limits change") > > due to race

Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-12 Thread Rafael J. Wysocki
On Mon, Feb 8, 2021 at 4:08 AM Yue Hu wrote: > > From: Yue Hu > > The limits_changed flag was introduced by commit 600f5badb78c > ("cpufreq: schedutil: Don't skip freq update when limits change") due > to race condition where need_freq_update is cleared in get_next_freq() > which causes reducing

Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-09 Thread Viresh Kumar
On 08-02-21, 11:07, Yue Hu wrote: > From: Yue Hu > > The limits_changed flag was introduced by commit 600f5badb78c > ("cpufreq: schedutil: Don't skip freq update when limits change") due > to race condition where need_freq_update is cleared in get_next_freq() > which causes reducing the CPU

[PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-07 Thread Yue Hu
From: Yue Hu The limits_changed flag was introduced by commit 600f5badb78c ("cpufreq: schedutil: Don't skip freq update when limits change") due to race condition where need_freq_update is cleared in get_next_freq() which causes reducing the CPU frequency is ineffective while busy. But now, the