Re: [PATCH] cpufreq: schedutil: fix equation in comment

2019-08-08 Thread Qais Yousef
On 08/07/19 11:42, Rafael J. Wysocki wrote: > On Monday, August 5, 2019 3:06:20 PM CEST Peter Zijlstra wrote: > > On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote: > > > scale_irq_capacity() call in schedutil_cpu_util() does > > > > > > util *= (max - irq) > > > util /= max > > > >

Re: [PATCH] cpufreq: schedutil: fix equation in comment

2019-08-07 Thread Rafael J. Wysocki
On Monday, August 5, 2019 3:06:20 PM CEST Peter Zijlstra wrote: > On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote: > > scale_irq_capacity() call in schedutil_cpu_util() does > > > > util *= (max - irq) > > util /= max > > > > But the comment says > > > > util *= (1 - irq)

Re: [PATCH] cpufreq: schedutil: fix equation in comment

2019-08-05 Thread Peter Zijlstra
On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote: > scale_irq_capacity() call in schedutil_cpu_util() does > > util *= (max - irq) > util /= max > > But the comment says > > util *= (1 - irq) > util /= max > > Fix the comment to match what the scaling function

Re: [PATCH] cpufreq: schedutil: fix equation in comment

2019-08-04 Thread Viresh Kumar
On 02-08-19, 11:46, Qais Yousef wrote: > scale_irq_capacity() call in schedutil_cpu_util() does > > util *= (max - irq) > util /= max > > But the comment says > > util *= (1 - irq) > util /= max > > Fix the comment to match what the scaling function does. > > Signed-off

Re: [PATCH] cpufreq: schedutil: fix equation in comment

2019-08-02 Thread Vincent Guittot
On Fri, 2 Aug 2019 at 12:46, Qais Yousef wrote: > > scale_irq_capacity() call in schedutil_cpu_util() does > > util *= (max - irq) > util /= max > > But the comment says > > util *= (1 - irq) > util /= max > > Fix the comment to match what the scaling function does.

[PATCH] cpufreq: schedutil: fix equation in comment

2019-08-02 Thread Qais Yousef
scale_irq_capacity() call in schedutil_cpu_util() does util *= (max - irq) util /= max But the comment says util *= (1 - irq) util /= max Fix the comment to match what the scaling function does. Signed-off-by: Qais Yousef --- kernel/sched/cpufreq_schedutil.c |