Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-12-25 Thread Rafael J. Wysocki
On Wednesday, December 25, 2013 11:39:07 PM Pavel Machek wrote: > Hi! > > > > > Well, disabling it for the whole duration of suspend/resume and/or > > > > hibernation > > > > may not be the right approach entirely, unless we force the pax perf of > > > > the > > > > > > s/pax/max ? > > > > Yes

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-12-25 Thread Pavel Machek
Hi! > > > Well, disabling it for the whole duration of suspend/resume and/or > > > hibernation > > > may not be the right approach entirely, unless we force the pax perf of > > > the > > > > s/pax/max ? > > Yes. I'm not sure max frequency is a good idea. In particular, early athlon64 notebook

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-25 Thread Rafael J. Wysocki
On Monday, November 25, 2013 09:55:19 AM Viresh Kumar wrote: > On 22 November 2013 14:41, viresh kumar wrote: > > So, what about something like this ? > > > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > > index f48370d..523c0bc 100644 > > --- a/drivers/base/cpu.c > > +++ b/drivers/base/

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-24 Thread Viresh Kumar
On 22 November 2013 14:41, viresh kumar wrote: > So, what about something like this ? > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index f48370d..523c0bc 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -120,6 +120,45 @@ static DEVICE_ATTR(release, S_IWUSR, NULL, >

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-22 Thread viresh kumar
On Friday 22 November 2013 03:44 AM, Rafael J. Wysocki wrote: > Short-term. To be precise, governors may be stopped at the beginning of > dpm_suspend_noirq() (that is, where cpuidle_pause() is called). Analogously, > they may be started again in dpm_resume_noirq(), where cpuidle_resume() is > cal

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-20 Thread Rafael J. Wysocki
On Wednesday, November 20, 2013 11:04:28 AM Viresh Kumar wrote: > On 18 November 2013 11:09, viresh kumar wrote: > > On 18 November 2013 03:07, Rafael J. Wysocki wrote: > >> On Sunday, November 17, 2013 10:27:43 PM Viresh Kumar wrote: > > > >>> Okay.. Even these notifiers would be fine for me. To

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-18 Thread Lan Tianyu
On 11/18/2013 01:39 PM, viresh kumar wrote: On 18 November 2013 03:07, Rafael J. Wysocki wrote: On Sunday, November 17, 2013 10:27:43 PM Viresh Kumar wrote: Okay.. Even these notifiers would be fine for me. To make things more clear before I start implementing them: - What about implementing

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-17 Thread Rafael J. Wysocki
On Sunday, November 17, 2013 10:27:43 PM Viresh Kumar wrote: > On 17 November 2013 20:39, Rafael J. Wysocki wrote: > > On Sunday, November 17, 2013 01:52:15 PM viresh kumar wrote: > > >> Do you see anything extra that might stop working? > > > > Well, the code would be racy with the patch as is.

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-16 Thread Viresh Kumar
On 16 November 2013 19:59, Rafael J. Wysocki wrote: > Well, disabling it for the whole duration of suspend/resume and/or hibernation > may not be the right approach entirely, unless we force the pax perf of the s/pax/max ? > boot CPU at least in addition to that. Otherwise the latency of suspe

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-16 Thread Rafael J. Wysocki
On Saturday, November 16, 2013 10:01:50 AM viresh kumar wrote: > On Saturday 16 November 2013 05:54 AM, Rafael J. Wysocki wrote: > > Will cpufreq work during system-wide power transitions (suspend/resume etc.) > > after this? In particular, what about hibernation? > > I am disabling governors as

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread Lan Tianyu
On 11/15/2013 06:12 PM, Viresh Kumar wrote: This patch adds PM notifiers for handling suspend/resume of cpufreq governors. This is required for early suspend and late resume of governors. There are multiple reasons that support this patch: - Firstly it looks very much logical to stop governors w

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread viresh kumar
On Saturday 16 November 2013 05:54 AM, Rafael J. Wysocki wrote: > Will cpufreq work during system-wide power transitions (suspend/resume etc.) > after this? In particular, what about hibernation? I am disabling governors as soon as we start suspend. So No, cpufreq wouldn't work during suspend/res

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread Rafael J. Wysocki
On Friday, November 15, 2013 03:42:29 PM Viresh Kumar wrote: > This patch adds PM notifiers for handling suspend/resume of cpufreq governors. > This is required for early suspend and late resume of governors. > > There are multiple reasons that support this patch: > - Firstly it looks very much lo

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread Viresh Kumar
On 15 November 2013 19:18, Nishanth Menon wrote: > Yes, this does fix the issue for me. > > Tested-by: Nishanth Menon > based on vendor kernel on top of v3.12 tag (equivalent diff: > http://pastebin.mozilla.org/3609407) > > OMAP5-uEVM(OMAP5432): http://pastebin.mozilla.org/3609396 Thanks a lot f

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread Nishanth Menon
On 11/15/2013 04:12 AM, Viresh Kumar wrote: > This patch adds PM notifiers for handling suspend/resume of cpufreq governors. > This is required for early suspend and late resume of governors. > > There are multiple reasons that support this patch: > - Firstly it looks very much logical to stop gov

[PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-11-15 Thread Viresh Kumar
This patch adds PM notifiers for handling suspend/resume of cpufreq governors. This is required for early suspend and late resume of governors. There are multiple reasons that support this patch: - Firstly it looks very much logical to stop governors when we know we are going into suspend. But t