Re: [PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-17 Thread Frederic Weisbecker
On Thu, Jul 18, 2019 at 12:27:09AM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 17, 2019 at 3:21 PM Frederic Weisbecker > wrote: > > > > On Wed, Jul 17, 2019 at 09:55:08AM +0200, Rafael J. Wysocki wrote: > > Well I think we disagree on that assumption that if a nohz_full CPU is put > > idle, it

Re: [PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-17 Thread Rafael J. Wysocki
On Wed, Jul 17, 2019 at 3:21 PM Frederic Weisbecker wrote: > > On Wed, Jul 17, 2019 at 09:55:08AM +0200, Rafael J. Wysocki wrote: > > On Tue, Jul 16, 2019 at 11:40 PM Frederic Weisbecker > > wrote: > > > > > > On Tue, Jul 16, 2019 at 05:25:10PM +0200, Rafael J. Wysocki wrote: > > > > From: Rafael

Re: [PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-17 Thread Frederic Weisbecker
On Wed, Jul 17, 2019 at 09:55:08AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 16, 2019 at 11:40 PM Frederic Weisbecker > wrote: > > > > On Tue, Jul 16, 2019 at 05:25:10PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Running the scheduler tick on idle adaptive-tick

Re: [PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-17 Thread Rafael J. Wysocki
On Tue, Jul 16, 2019 at 11:40 PM Frederic Weisbecker wrote: > > On Tue, Jul 16, 2019 at 05:25:10PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Running the scheduler tick on idle adaptive-tick CPUs is not useful > > Judging by the below change, you mean full dynticks, right

Re: [PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-16 Thread Frederic Weisbecker
On Tue, Jul 16, 2019 at 05:25:10PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Running the scheduler tick on idle adaptive-tick CPUs is not useful Judging by the below change, you mean full dynticks, right? > and it may also be not expected by users (as reported by Thomas), so

[PATCH] cpuidle: Always stop scheduler tick on adaptive-tick CPUs

2019-07-16 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Running the scheduler tick on idle adaptive-tick CPUs is not useful and it may also be not expected by users (as reported by Thomas), so add a check to cpuidle_idle_call() to always stop the tick on them regardless of the idle duration predicted by the governor. Fixes: 55