Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-18 Thread Daniel Lezcano
On 10/17/2012 08:43 PM, Julius Werner wrote: >> This is specific to the acpi and should be handled in the >> processor_idle.c file instead of the cpuidle core code. >> >> Could be the function 'acpi_processor_cst_has_changed' the right place >> to set a dummy power value for the power in the new

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-18 Thread Daniel Lezcano
On 10/17/2012 08:43 PM, Julius Werner wrote: This is specific to the acpi and should be handled in the processor_idle.c file instead of the cpuidle core code. Could be the function 'acpi_processor_cst_has_changed' the right place to set a dummy power value for the power in the new C-state ?

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Julius Werner
> This is specific to the acpi and should be handled in the > processor_idle.c file instead of the cpuidle core code. > > Could be the function 'acpi_processor_cst_has_changed' the right place > to set a dummy power value for the power in the new C-state ? Thanks for your feedback. I think it

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Daniel Lezcano
On 10/17/2012 12:31 PM, Daniel Lezcano wrote: > On 10/17/2012 12:39 AM, Julius Werner wrote: >> When cpuidle drivers do not supply explicit power_usage values, >> cpuidle/driver.c inserts dummy values instead. When a running processor >> dynamically gains new C-states (e.g. after ACPI events), the

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Daniel Lezcano
On 10/17/2012 12:39 AM, Julius Werner wrote: > When cpuidle drivers do not supply explicit power_usage values, > cpuidle/driver.c inserts dummy values instead. When a running processor > dynamically gains new C-states (e.g. after ACPI events), the power_usage > values of those states will stay

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Daniel Lezcano
On 10/17/2012 12:39 AM, Julius Werner wrote: When cpuidle drivers do not supply explicit power_usage values, cpuidle/driver.c inserts dummy values instead. When a running processor dynamically gains new C-states (e.g. after ACPI events), the power_usage values of those states will stay

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Daniel Lezcano
On 10/17/2012 12:31 PM, Daniel Lezcano wrote: On 10/17/2012 12:39 AM, Julius Werner wrote: When cpuidle drivers do not supply explicit power_usage values, cpuidle/driver.c inserts dummy values instead. When a running processor dynamically gains new C-states (e.g. after ACPI events), the

Re: [PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-17 Thread Julius Werner
This is specific to the acpi and should be handled in the processor_idle.c file instead of the cpuidle core code. Could be the function 'acpi_processor_cst_has_changed' the right place to set a dummy power value for the power in the new C-state ? Thanks for your feedback. I think it wouldn't

[PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-16 Thread Julius Werner
When cpuidle drivers do not supply explicit power_usage values, cpuidle/driver.c inserts dummy values instead. When a running processor dynamically gains new C-states (e.g. after ACPI events), the power_usage values of those states will stay uninitialized, and cpuidle governors will never choose

[PATCH] cpuidle: reinitialize power_usage values when adding/removing C-states

2012-10-16 Thread Julius Werner
When cpuidle drivers do not supply explicit power_usage values, cpuidle/driver.c inserts dummy values instead. When a running processor dynamically gains new C-states (e.g. after ACPI events), the power_usage values of those states will stay uninitialized, and cpuidle governors will never choose