Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
On 12/12/2012 11:42 PM, Rafael J. Wysocki wrote: > On Wednesday, December 12, 2012 09:00:53 PM Daniel Lezcano wrote: >> On 12/12/2012 07:50 PM, Julius Werner wrote: >>> Thanks again for making this happen, Daniel. I like this version, >>> except for the small nitpick that I still think it would

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Rafael J. Wysocki
On Wednesday, December 12, 2012 09:00:53 PM Daniel Lezcano wrote: > On 12/12/2012 07:50 PM, Julius Werner wrote: > > Thanks again for making this happen, Daniel. I like this version, > > except for the small nitpick that I still think it would make sense to > > also turn the loop in menu.c around.

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
On 12/12/2012 07:50 PM, Julius Werner wrote: > Thanks again for making this happen, Daniel. I like this version, > except for the small nitpick that I still think it would make sense to > also turn the loop in menu.c around. How about something like this: > >for (i = drv->state_count - 1;

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Julius Werner
Thanks again for making this happen, Daniel. I like this version, except for the small nitpick that I still think it would make sense to also turn the loop in menu.c around. How about something like this: for (i = drv->state_count - 1; i >= CPUIDLE_DRIVER_STATE_START; i++) {

[PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
This patch follows the discussion about reinitializing the power usage when a C-state is added/removed. https://lkml.org/lkml/2012/10/16/518 We realized the power usage field is never filled and when it is filled for tegra, the power_specified flag is not set making all these values to be

[PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
This patch follows the discussion about reinitializing the power usage when a C-state is added/removed. https://lkml.org/lkml/2012/10/16/518 We realized the power usage field is never filled and when it is filled for tegra, the power_specified flag is not set making all these values to be

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Julius Werner
Thanks again for making this happen, Daniel. I like this version, except for the small nitpick that I still think it would make sense to also turn the loop in menu.c around. How about something like this: for (i = drv-state_count - 1; i = CPUIDLE_DRIVER_STATE_START; i++) {

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
On 12/12/2012 07:50 PM, Julius Werner wrote: Thanks again for making this happen, Daniel. I like this version, except for the small nitpick that I still think it would make sense to also turn the loop in menu.c around. How about something like this: for (i = drv-state_count - 1; i =

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Rafael J. Wysocki
On Wednesday, December 12, 2012 09:00:53 PM Daniel Lezcano wrote: On 12/12/2012 07:50 PM, Julius Werner wrote: Thanks again for making this happen, Daniel. I like this version, except for the small nitpick that I still think it would make sense to also turn the loop in menu.c around. How

Re: [PATCH] cpuidle - remove the power_specified field in the driver

2012-12-12 Thread Daniel Lezcano
On 12/12/2012 11:42 PM, Rafael J. Wysocki wrote: On Wednesday, December 12, 2012 09:00:53 PM Daniel Lezcano wrote: On 12/12/2012 07:50 PM, Julius Werner wrote: Thanks again for making this happen, Daniel. I like this version, except for the small nitpick that I still think it would make sense