Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-28 Thread Tejun Heo
On Thu, Nov 24, 2016 at 08:55:12PM -0800, Kirtika Ruchandani wrote: > 'struct cpuset* cs' that is set but not used, was introduced in commit > 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from > subtree_control enabling"). > cpuset_cancel_attach() uses css_cs(css) instead. Co

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-28 Thread Tejun Heo
Hello, On Mon, Nov 28, 2016 at 08:37:09AM +0100, Michal Hocko wrote: > I would disagree here. Randomly picking up fixes just because they are > Fixing some commit is just too dangerous for the stable trees. Fixes tag > should tell what was the culprit of the issue fixed by the patch, > nothing mor

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-27 Thread Michal Hocko
On Sat 26-11-16 08:42:40, Li Zefan wrote: > On 2016/11/25 17:46, Arnd Bergmann wrote: > > On Friday, November 25, 2016 1:46:04 PM CET Zefan Li wrote: > >> On 2016/11/25 12:55, Kirtika Ruchandani wrote: > >>> 'struct cpuset* cs' that is set but not used, was introduced in commit > >>> 1f7dd3e5a6e4 (

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-25 Thread Zefan Li
On 2016/11/25 17:46, Arnd Bergmann wrote: > On Friday, November 25, 2016 1:46:04 PM CET Zefan Li wrote: >> On 2016/11/25 12:55, Kirtika Ruchandani wrote: >>> 'struct cpuset* cs' that is set but not used, was introduced in commit >>> 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-25 Thread Arnd Bergmann
On Friday, November 25, 2016 1:46:04 PM CET Zefan Li wrote: > On 2016/11/25 12:55, Kirtika Ruchandani wrote: > > 'struct cpuset* cs' that is set but not used, was introduced in commit > > 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from > > subtree_control enabling"). > > cp

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-24 Thread Zefan Li
On 2016/11/25 12:55, Kirtika Ruchandani wrote: > 'struct cpuset* cs' that is set but not used, was introduced in commit > 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from > subtree_control enabling"). > cpuset_cancel_attach() uses css_cs(css) instead. Compiling with W=1 > gi

[PATCH] cpuset: Remove unused 'struct cpuset*' variable

2016-11-24 Thread Kirtika Ruchandani
'struct cpuset* cs' that is set but not used, was introduced in commit 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from subtree_control enabling"). cpuset_cancel_attach() uses css_cs(css) instead. Compiling with W=1 gives the folllowing harmless warning, which we'd like to f