Re: [PATCH] cris: kgdb: use native hex2bin

2015-09-30 Thread Jesper Nilsson
On Wed, Sep 30, 2015 at 08:02:34PM +0200, Jesper Nilsson wrote: > On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote: > > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > > > On Tue, 2013-06-04 at 11:51

Re: [PATCH] cris: kgdb: use native hex2bin

2015-09-30 Thread Jesper Nilsson
On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote: > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > > > There are kernel native helpers to

Re: [PATCH] cris: kgdb: use native hex2bin

2015-09-30 Thread Andy Shevchenko
On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > > There are kernel native helpers to convert hex ascii to the > > > binary > > > format: > > > hex_to_bin()

Re: [PATCH] cris: kgdb: use native hex2bin

2015-09-30 Thread Jesper Nilsson
On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > There are kernel native helpers to convert hex ascii to the binary > > format: > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them > > customly. > > > >

Re: [PATCH] cris: kgdb: use native hex2bin

2015-09-30 Thread Andy Shevchenko
On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > There are kernel native helpers to convert hex ascii to the binary > format: > hex_to_bin() and hex2bin(). Thus, no need to reimplement them > customly. > No one is interested in this? > Signed-off-by: Andy Shevchenko > Cc: Geert Uyt

Re: [PATCH] cris: kgdb: use native hex2bin

2013-06-04 Thread Andy Shevchenko
On Tue, Jun 4, 2013 at 11:51 AM, Andy Shevchenko wrote: > There are kernel native helpers to convert hex ascii to the binary format: > hex_to_bin() and hex2bin(). Thus, no need to reimplement them customly. > > Signed-off-by: Andy Shevchenko > Cc: Geert Uytterhoeven Forgot to mention this is v2

[PATCH] cris: kgdb: use native hex2bin

2013-06-04 Thread Andy Shevchenko
There are kernel native helpers to convert hex ascii to the binary format: hex_to_bin() and hex2bin(). Thus, no need to reimplement them customly. Signed-off-by: Andy Shevchenko Cc: Geert Uytterhoeven --- arch/cris/arch-v10/kernel/kgdb.c | 36 +++-- arch/cris/arch-v32/kernel

Re: [PATCH] cris: kgdb: use native hex2bin

2013-05-30 Thread Andy Shevchenko
On Thu, May 30, 2013 at 10:57 AM, Geert Uytterhoeven wrote: > On Tue, May 28, 2013 at 5:53 PM, Andy Shevchenko > wrote: >> diff --git a/arch/cris/arch-v10/kernel/kgdb.c >> b/arch/cris/arch-v10/kernel/kgdb.c >> index 37e6d2c..07bccd8 100644 >> --- a/arch/cris/arch-v10/kernel/kgdb.c >> +++ b/arch/

Re: [PATCH] cris: kgdb: use native hex2bin

2013-05-30 Thread Geert Uytterhoeven
On Tue, May 28, 2013 at 5:53 PM, Andy Shevchenko wrote: > diff --git a/arch/cris/arch-v10/kernel/kgdb.c > b/arch/cris/arch-v10/kernel/kgdb.c > index 37e6d2c..07bccd8 100644 > --- a/arch/cris/arch-v10/kernel/kgdb.c > +++ b/arch/cris/arch-v10/kernel/kgdb.c > @@ -659,18 +651,6 @@ read_register (cha

[PATCH] cris: kgdb: use native hex2bin

2013-05-28 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- arch/cris/arch-v10/kernel/kgdb.c | 50 ++-- 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c index 37e6d2c..07bccd8 100644 --- a/arch/cris/arch-