Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Rushikesh S Kadam
Thanks Enric, Jett, Gwendal & Andy for taking timeout to review the patch & provide detailed inputs. Couple of acks below. On Thu, Feb 28, 2019 at 01:33:09PM +0100, Enric Balletbo Serra wrote: > Hi, > > Based on the discussion we had, only some few comments. > > Missatge de Rushikesh S Kadam

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Gwendal Grignou
On Thu, Feb 28, 2019 at 4:18 AM Enric Balletbo Serra wrote: > > Hi Andy, > Missatge de Andy Shevchenko del dia dj., > 28 de febr. 2019 a les 8:57: > > > > On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote: > > > Missatge de Gwendal Grignou del dia dc., 27 de > > > febr. 2019

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Enric Balletbo Serra
Hi, Based on the discussion we had, only some few comments. Missatge de Rushikesh S Kadam del dia dg., 24 de febr. 2019 a les 10:15: > > Intel Integrated Sensor Hub (ISH) is also a MCU running EC > having feature bit EC_FEATURE_ISH. Instantiate it as a special > CrOS EC device with device name

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Enric Balletbo Serra
Hi Andy, Missatge de Andy Shevchenko del dia dj., 28 de febr. 2019 a les 8:57: > > On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote: > > Missatge de Gwendal Grignou del dia dc., 27 de > > febr. 2019 a les 19:37: > > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra >

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Andy Shevchenko
On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote: > Missatge de Gwendal Grignou del dia dc., 27 de > febr. 2019 a les 19:37: > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra > > wrote: > > > On 27/2/19 16:13, Jett Rink wrote: > > You're right, the cros_ names are

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Enric Balletbo Serra
Hi Gwendal, Missatge de Gwendal Grignou del dia dc., 27 de febr. 2019 a les 19:37: > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra > wrote: > > > > Hi Jett, > > > > Many thanks for the explanation. > > > > On 27/2/19 16:13, Jett Rink wrote: > > > The diagram you provided is correct.

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Gwendal Grignou
On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra wrote: > > Hi Jett, > > Many thanks for the explanation. > > On 27/2/19 16:13, Jett Rink wrote: > > The diagram you provided is correct. > > > > The ISH device is a MCU that can run general purpose code that is > > located on the SoC.

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Enric Balletbo i Serra
Hi Jett, Many thanks for the explanation. On 27/2/19 16:13, Jett Rink wrote: > The diagram you provided is correct. > > The ISH device is a MCU that can run general purpose code that is > located on the SoC. Typically the ISH collects sensor data and > processes it before giving it to the AP.

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Jett Rink
The diagram you provided is correct. The ISH device is a MCU that can run general purpose code that is located on the SoC. Typically the ISH collects sensor data and processes it before giving it to the AP. The ISH HW can run any RTOS, and in this scenario we are choosing to run the ECOS RTOS. In

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Enric Balletbo i Serra
Hi, On 26/2/19 18:21, Jett Rink wrote: > We are specifically wanting userspace applications to not worry/confuse > cros_ish > with a normal cros_ec. Adding an attribute instead of changing the path would > make it easy for userspace application to forget to check properly before > accessing the

[PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-24 Thread Rushikesh S Kadam
Intel Integrated Sensor Hub (ISH) is also a MCU running EC having feature bit EC_FEATURE_ISH. Instantiate it as a special CrOS EC device with device name 'cros_ish'. Signed-off-by: Rushikesh S Kadam --- drivers/mfd/cros_ec_dev.c| 10 ++ include/linux/mfd/cros_ec.h |