Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-17 Thread Herbert Xu
On Mon, May 16, 2016 at 04:07:53PM -0700, Megha Dey wrote: > > ok. I tried at my end too using some printk's and nothing seems to be > broken. Also, if you intend to use the same commit message, I spell my > name as Megha Dey and not Day :) Patch applied with the name corrected. Thanks, --

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-17 Thread Herbert Xu
On Mon, May 16, 2016 at 04:07:53PM -0700, Megha Dey wrote: > > ok. I tried at my end too using some printk's and nothing seems to be > broken. Also, if you intend to use the same commit message, I spell my > name as Megha Dey and not Day :) Patch applied with the name corrected. Thanks, --

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Megha Dey
; sha1_mb_mgr_flush_avx2()+0x20d: call without frame pointer > > > > > > save/setup > > > > > > > > > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > > > sha1_mb_mgr_submit_avx2()+0x115:

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Megha Dey
all without frame pointer > > > > > > save/setup > > > > > > > > > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > > > sha1_mb_mgr_submit_avx2()+0x115: call without frame pointer > >

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Josh Poimboeuf
vx2()+0x20d: call without frame pointer save/setup > > > > > > > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > > sha1_mb_mgr_submit_avx2()+0x115: call without frame pointer save/setup > > > > > > > &

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Josh Poimboeuf
/setup > > > > > > > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > > sha1_mb_mgr_submit_avx2()+0x115: call without frame pointer save/setup > > > > > > > > Megha, > >

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Megha Dey
thout frame pointer save/setup > > > > > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > sha1_mb_mgr_submit_avx2()+0x115: call without frame pointer save/setup > > > > > > Megha, > > > > > > Sorr

Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Megha Dey
> > > > > arch/x86/crypto/sha1-mb/sha1_mb_mgr_submit_avx2.o: warning: objtool: > > > > sha1_mb_mgr_submit_avx2()+0x115: call without frame pointer save/setup > > > > > > Megha, > > > > > > Sorry for breaking it. I completely miss

[PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Josh Poimboeuf
y isn't too bad, I'll submit a patch to > > standardize sha1_x8_avx2() to follow the C ABI. > > > > Do you have any tips for testing this code? I've tried using the tcrypt > > module, but no luck. > > > Josh, > Build the kernel with the following configs: > CO

[PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI

2016-05-16 Thread Josh Poimboeuf
x115: call without frame pointer save/setup > > > > Megha, > > > > Sorry for breaking it. I completely missed the fact that the function > > calls sha1_x8_avx2() which clobbers registers. > > > > If the performance penalty isn't too bad, I'll submit a patch to