Re: [PATCH] crypto/testmgr.c: fix !x==y confusion

2016-08-09 Thread Herbert Xu
On Fri, Jul 29, 2016 at 04:32:09PM +0800, yanjiang@windriver.com wrote: > From: Yanjiang Jin > > "if (!ret == template[i].fail)" is confusing to compilers (gcc5): > > crypto/testmgr.c: In function '__test_aead': > crypto/testmgr.c:531:12: warning: logical not is only applied to the > left ha

[PATCH] crypto/testmgr.c: fix !x==y confusion

2016-07-29 Thread yanjiang.jin
From: Yanjiang Jin "if (!ret == template[i].fail)" is confusing to compilers (gcc5): crypto/testmgr.c: In function '__test_aead': crypto/testmgr.c:531:12: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!ret == template[i].fail) {