Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

2020-11-05 Thread Herbert Xu
On Wed, Oct 28, 2020 at 11:03:20AM +0200, Horia Geantă wrote: > Loading the module deadlocks since: > -local cbc(aes) implementation needs a fallback and > -crypto API tries to find one but the request_module() resolves back to > the same module > > Fix this by changing the module alias for cbc(ae

Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

2020-10-29 Thread Herbert Xu
On Wed, Oct 28, 2020 at 10:06:58AM +0100, Ard Biesheuvel wrote: > > Not sure what is happening here: IIRC the intention was to rely on the > fact that only the sync cbc(aes) implementation needs the fallback, > and therefore, allocating a sync skcipher explicitly would avoid this > recursion. > >

Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

2020-10-28 Thread Ard Biesheuvel
On Wed, 28 Oct 2020 at 10:03, Horia Geantă wrote: > > Loading the module deadlocks since: > -local cbc(aes) implementation needs a fallback and > -crypto API tries to find one but the request_module() resolves back to > the same module > > Fix this by changing the module alias for cbc(aes) and > u

[PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

2020-10-28 Thread Horia Geantă
Loading the module deadlocks since: -local cbc(aes) implementation needs a fallback and -crypto API tries to find one but the request_module() resolves back to the same module Fix this by changing the module alias for cbc(aes) and using the NEED_FALLBACK flag when requesting for a fallback algorit

Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

2020-10-28 Thread Horia Geantă
On 10/28/2020 11:07 AM, Ard Biesheuvel wrote: > On Wed, 28 Oct 2020 at 10:03, Horia Geantă wrote: >> >> Loading the module deadlocks since: >> -local cbc(aes) implementation needs a fallback and >> -crypto API tries to find one but the request_module() resolves back to >> the same module >> >> Fix