Re: [PATCH] crypto: ccree - avoid implicit enum conversion

2018-10-11 Thread Gilad Ben-Yossef
Hi Nick, On Thu, Oct 11, 2018 at 2:49 AM Nick Desaulniers wrote: > > $ grep -r set_cipher_config0 -n > > shows a healthy mix of DESC_DIRECTION_ENCRYPT_ENCRYPT, > HASH_DIGEST_RESULT_LITTLE_ENDIAN, and DRV_CRYPTO_DIRECTION_ENCRYPT > (all enumeration values of different enums). > > > > > drivers/cry

Re: [PATCH] crypto: ccree - avoid implicit enum conversion

2018-10-11 Thread Gilad Ben-Yossef
Hi Nathan, On Thu, Oct 11, 2018 at 12:44 AM Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another > and this happens in several locations in this driver, ultimately related > to the set_cipher_{mode,config0} functions. set_cipher_mode expects a mode