Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Geert Uytterhoeven
Hi Stephan, On Tue, Jun 23, 2015 at 3:01 PM, Stephan Mueller wrote: >> On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: >> > I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. >> > >> > With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Stephan Mueller
Am Dienstag, 23. Juni 2015, 17:21:06 schrieb Herbert Xu: Hi Herbert, > On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: > > I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. > > > > With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due > >

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Stephan Mueller
Am Dienstag, 23. Juni 2015, 17:21:06 schrieb Herbert Xu: Hi Herbert, >On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: >> I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. >> >> With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due >> to

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Herbert Xu
On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: > > I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. > > With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due > to the good unused warning reporting, I get: > > crypto/jitterentropy.c:235:

#pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Geert Uytterhoeven
On Tue, Jun 9, 2015 at 6:31 AM, Guenter Roeck wrote: > On 06/08/2015 07:08 PM, Stephan Mueller wrote: >> ---8<--- >> Replace the global -O0 compiler flag from the Makefile with GCC >> pragmas to mark only the functions required to be compiled without >> optimizations. >> >> This patch also adds a

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Geert Uytterhoeven
Hi Stephan, On Tue, Jun 23, 2015 at 3:01 PM, Stephan Mueller smuel...@chronox.de wrote: On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. With m68k-linux-gnu-gcc-4.1, which is still my default

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Stephan Mueller
Am Dienstag, 23. Juni 2015, 17:21:06 schrieb Herbert Xu: Hi Herbert, On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due to the

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Stephan Mueller
Am Dienstag, 23. Juni 2015, 17:21:06 schrieb Herbert Xu: Hi Herbert, On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due to the good

#pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Geert Uytterhoeven
On Tue, Jun 9, 2015 at 6:31 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/08/2015 07:08 PM, Stephan Mueller wrote: ---8--- Replace the global -O0 compiler flag from the Makefile with GCC pragmas to mark only the functions required to be compiled without optimizations. This patch also

Re: #pragma GCC warnings (was: Re: [PATCH] crypto: drbg - use pragmas for disabling optimization)

2015-06-23 Thread Herbert Xu
On Tue, Jun 23, 2015 at 11:17:23AM +0200, Geert Uytterhoeven wrote: I get that too with m68k-linux-gcc-4.6.3 and m68k-linux-gcc-4.9.0. With m68k-linux-gnu-gcc-4.1, which is still my default cross-compiler due to the good unused warning reporting, I get: crypto/jitterentropy.c:235:

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-09 Thread Herbert Xu
On Tue, Jun 09, 2015 at 04:08:49AM +0200, Stephan Mueller wrote: > > Replace the global -O0 compiler flag from the Makefile with GCC > pragmas to mark only the functions required to be compiled without > optimizations. > > This patch also adds a comment describing the rationale for the >

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-09 Thread Herbert Xu
On Tue, Jun 09, 2015 at 04:08:49AM +0200, Stephan Mueller wrote: Replace the global -O0 compiler flag from the Makefile with GCC pragmas to mark only the functions required to be compiled without optimizations. This patch also adds a comment describing the rationale for the functions

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Guenter Roeck
On 06/08/2015 07:08 PM, Stephan Mueller wrote: Hi, I performed measurements of the upper and lower boundary of the minimum and Shannon entropy for the RNG before the patch and after the patch. The values are very similar which demonstrates that the change does not affect the cryptographic

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Stephen Rothwell
Hi Stephan, On Tue, 09 Jun 2015 04:08:49 +0200 Stephan Mueller wrote: > > Replace the global -O0 compiler flag from the Makefile with GCC > pragmas to mark only the functions required to be compiled without > optimizations. > > This patch also adds a comment describing the rationale for the >

[PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Stephan Mueller
Hi, I performed measurements of the upper and lower boundary of the minimum and Shannon entropy for the RNG before the patch and after the patch. The values are very similar which demonstrates that the change does not affect the cryptographic characteristics of the RNG. The tests are available

[PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Stephan Mueller
Hi, I performed measurements of the upper and lower boundary of the minimum and Shannon entropy for the RNG before the patch and after the patch. The values are very similar which demonstrates that the change does not affect the cryptographic characteristics of the RNG. The tests are available

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Guenter Roeck
On 06/08/2015 07:08 PM, Stephan Mueller wrote: Hi, I performed measurements of the upper and lower boundary of the minimum and Shannon entropy for the RNG before the patch and after the patch. The values are very similar which demonstrates that the change does not affect the cryptographic

Re: [PATCH] crypto: drbg - use pragmas for disabling optimization

2015-06-08 Thread Stephen Rothwell
Hi Stephan, On Tue, 09 Jun 2015 04:08:49 +0200 Stephan Mueller smuel...@chronox.de wrote: Replace the global -O0 compiler flag from the Makefile with GCC pragmas to mark only the functions required to be compiled without optimizations. This patch also adds a comment describing the