Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-12 Thread Bjorn Andersson
On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- > drivers/crypto/qce/core.h | 2 +- > 2 files changed, 18 insertions(+), 2

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-12 Thread Bjorn Andersson
On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- > drivers/crypto/qce/core.h | 2 +- > 2 files changed, 18 insertions(+), 2 deletions(-) > >

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Iaroslav Gridin
> > + ret = clk_set_rate(qce->core_src, 1); > > Could you point me from where you got this number? I got it from codeaurora qce driver: https://android.googlesource.com/kernel/msm/+/android-msm-hammerhead-3.4-kk-r1/drivers/crypto/msm/qce50.c#3386

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Iaroslav Gridin
> > + ret = clk_set_rate(qce->core_src, 1); > > Could you point me from where you got this number? I got it from codeaurora qce driver: https://android.googlesource.com/kernel/msm/+/android-msm-hammerhead-3.4-kk-r1/drivers/crypto/msm/qce50.c#3386

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Iaroslav Gridin
On Wed, Sep 07, 2016 at 04:04:01PM +0300, Stanimir Varbanov wrote: > Hi Iaroslav, > > On 09/03/2016 07:45 PM, Iaroslav Gridin wrote: > > Without that, QCE performance is about 2x less. > > On which platform? The clock rates are per SoC. Dragonboard 8074. Should clock rate be moved to its DT? >

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Iaroslav Gridin
On Wed, Sep 07, 2016 at 04:04:01PM +0300, Stanimir Varbanov wrote: > Hi Iaroslav, > > On 09/03/2016 07:45 PM, Iaroslav Gridin wrote: > > Without that, QCE performance is about 2x less. > > On which platform? The clock rates are per SoC. Dragonboard 8074. Should clock rate be moved to its DT? >

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Stanimir Varbanov
Hi Iaroslav, On 09/03/2016 07:45 PM, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. On which platform? The clock rates are per SoC. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- >

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Stanimir Varbanov
Hi Iaroslav, On 09/03/2016 07:45 PM, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. On which platform? The clock rates are per SoC. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- > drivers/crypto/qce/core.h | 2 +- > 2

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Herbert Xu
On Sat, Sep 03, 2016 at 07:45:35PM +0300, Iaroslav Gridin wrote: > > @@ -247,6 +261,8 @@ err_clks_iface: > clk_disable_unprepare(qce->iface); > err_clks_core: > clk_disable_unprepare(qce->core); > +err_clks_core_src: > + clk_disable_unprepare(qce->core_src); What about

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-07 Thread Herbert Xu
On Sat, Sep 03, 2016 at 07:45:35PM +0300, Iaroslav Gridin wrote: > > @@ -247,6 +261,8 @@ err_clks_iface: > clk_disable_unprepare(qce->iface); > err_clks_core: > clk_disable_unprepare(qce->core); > +err_clks_core_src: > + clk_disable_unprepare(qce->core_src); What about

[PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-03 Thread Iaroslav Gridin
Without that, QCE performance is about 2x less. Signed-off-by: Iaroslav Gridin --- drivers/crypto/qce/core.c | 18 +- drivers/crypto/qce/core.h | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qce/core.c

[PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-03 Thread Iaroslav Gridin
Without that, QCE performance is about 2x less. Signed-off-by: Iaroslav Gridin --- drivers/crypto/qce/core.c | 18 +- drivers/crypto/qce/core.h | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c index