> If you can't work out why authenc.c needs slab.h I don't think
> you should be submitting patches removing unnecessary header
> files.
[]
You left out "kernel.h".
I really hoped this would not be your answer.
Yes, I'm an ignorant and yes, I ask questions. But if all you got is this type
of a
On Thu, Dec 05, 2013 at 08:14:55AM +, Cristian Stoica wrote:
> Hi Herbert,
>
> Your original response was terse and left me more puzzled. Do you have a
> sensible explanation why some includes should be kept in the source even they
> serve no purpose during the build?
If you can't work out
Hi Herbert,
Your original response was terse and left me more puzzled. Do you have a
sensible explanation why some includes should be kept in the source even they
serve no purpose during the build?
Thanks,
Cristian S.
> > Just because it compiles it doesn't meant that the files you
> > remo
> On Fri, Nov 29, 2013 at 08:49:42AM +, Cristian Stoica wrote:
> > >From what I could see there is nothing from those includes that is
> used inside authenc.c.
> > The build passes without them.
>
> Just because it compiles it doesn't meant that the files you
> removed are unnecessary.
>
> Th
On Fri, Nov 29, 2013 at 08:49:42AM +, Cristian Stoica wrote:
> >From what I could see there is nothing from those includes that is used
> >inside authenc.c.
> The build passes without them.
Just because it compiles it doesn't meant that the files you
removed are unnecessary.
The only file th
>From what I could see there is nothing from those includes that is used inside
>authenc.c.
The build passes without them.
Cristian S.
> > diff --git a/crypto/authenc.c b/crypto/authenc.c
> > index 1875e70..7d4bfaa 100644
> > --- a/crypto/authenc.c
> > +++ b/crypto/authenc.c
> > @@ -17,11 +17,8
On Thu, Nov 28, 2013 at 07:16:27PM +0200, Cristian Stoica wrote:
> Signed-off-by: Cristian Stoica
> ---
> crypto/authenc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/crypto/authenc.c b/crypto/authenc.c
> index 1875e70..7d4bfaa 100644
> --- a/crypto/authenc.c
> +++ b/crypto/authen
Signed-off-by: Cristian Stoica
---
crypto/authenc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/crypto/authenc.c b/crypto/authenc.c
index 1875e70..7d4bfaa 100644
--- a/crypto/authenc.c
+++ b/crypto/authenc.c
@@ -17,11 +17,8 @@
#include
#include
#include
-#include
#include
#inc
8 matches
Mail list logo