Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-24 Thread Herbert Xu
On Tue, Aug 23, 2016 at 08:28:54PM +0530, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has

Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-24 Thread Herbert Xu
On Tue, Aug 23, 2016 at 08:28:54PM +0530, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has

Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-23 Thread Heiko Stübner
Am Dienstag, 23. August 2016, 20:28:54 schrieb Sudip Mukherjee: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has

Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-23 Thread Heiko Stübner
Am Dienstag, 23. August 2016, 20:28:54 schrieb Sudip Mukherjee: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has

[PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-23 Thread Sudip Mukherjee
If devm_add_action() fails we are explicitly calling the cleanup to free the resources allocated. Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that the cleanup function has been already called by the helper if there was any error. Signed-off-by:

[PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-23 Thread Sudip Mukherjee
If devm_add_action() fails we are explicitly calling the cleanup to free the resources allocated. Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that the cleanup function has been already called by the helper if there was any error. Signed-off-by: