Re: [PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 14:45:13 +0100 > -static unsigned int get_filter_steerq(struct net_device *dev, > +static int get_filter_steerq(struct net_device *dev, > struct ch_filter_specification *fs) If you change the

Re: [PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 14:45:13 +0100 > -static unsigned int get_filter_steerq(struct net_device *dev, > +static int get_filter_steerq(struct net_device *dev, > struct ch_filter_specification *fs) If you change the location of the openning

[PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-23 Thread Colin King
From: Colin Ian King iq is unsigned, so the error check for iq < 0 has no effect so errors can slip past this check. Fix this by making iq signed and also get_filter_steerq return a signed int so a -ve error can be returned. Signed-off-by: Colin Ian King

[PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-23 Thread Colin King
From: Colin Ian King iq is unsigned, so the error check for iq < 0 has no effect so errors can slip past this check. Fix this by making iq signed and also get_filter_steerq return a signed int so a -ve error can be returned. Signed-off-by: Colin Ian King ---