Re: [PATCH] cxgb4: use dev_port to identify ports

2014-06-26 Thread Thadeu Lima de Souza Cascardo
On Wed, Jun 25, 2014 at 04:08:21PM -0700, Luis R. Rodriguez wrote: > On Sat, Jun 21, 2014 at 5:48 AM, Thadeu Lima de Souza Cascardo > wrote: > > That use was removed by commit > > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set > > net_device::dev_id to VI index"), since dev_id should

Re: [PATCH] cxgb4: use dev_port to identify ports

2014-06-25 Thread Luis R. Rodriguez
On Sat, Jun 21, 2014 at 5:48 AM, Thadeu Lima de Souza Cascardo wrote: > That use was removed by commit > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set > net_device::dev_id to VI index"), since dev_id should be used only when > devices share the same MAC address. > > Using dev_port f

Re: [PATCH] cxgb4: use dev_port to identify ports

2014-06-25 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Mon, 23 Jun 2014 09:16:40 -0300 > On Sun, Jun 22, 2014 at 05:23:07PM -0700, David Miller wrote: >> From: Thadeu Lima de Souza Cascardo >> Date: Sat, 21 Jun 2014 09:48:08 -0300 >> >> > Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file

Re: [PATCH] cxgb4: use dev_port to identify ports

2014-06-23 Thread Thadeu Lima de Souza Cascardo
On Sun, Jun 22, 2014 at 05:23:07PM -0700, David Miller wrote: > From: Thadeu Lima de Souza Cascardo > Date: Sat, 21 Jun 2014 09:48:08 -0300 > > > Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file > > for port number") introduce dev_port to network devices. cxgb4 adapters > > h

Re: [PATCH] cxgb4: use dev_port to identify ports

2014-06-22 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Sat, 21 Jun 2014 09:48:08 -0300 > Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file > for port number") introduce dev_port to network devices. cxgb4 adapters > have multiple ports on the same PCI function, and used dev_id to > identify

[PATCH] cxgb4: use dev_port to identify ports

2014-06-21 Thread Thadeu Lima de Souza Cascardo
Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file for port number") introduce dev_port to network devices. cxgb4 adapters have multiple ports on the same PCI function, and used dev_id to identify those ports. That use was removed by commit 8c367fcbe6549195d2eb11e62bea233f811aad4