Re: [PATCH] dax: Fix last_page check in __bdev_dax_supported()

2019-05-20 Thread Dan Williams
On Thu, May 16, 2019 at 10:37 PM Vaibhav Jain wrote: > > Dan Williams writes: > > > On Wed, May 15, 2019 at 10:55 PM Vaibhav Jain wrote: > >> > >> Presently __bdev_dax_supported() checks if first sector of last > >> page ( last_page ) on the block device is aligned to page > >> boundary. However

Re: [PATCH] dax: Fix last_page check in __bdev_dax_supported()

2019-05-16 Thread Vaibhav Jain
Dan Williams writes: > On Wed, May 15, 2019 at 10:55 PM Vaibhav Jain wrote: >> >> Presently __bdev_dax_supported() checks if first sector of last >> page ( last_page ) on the block device is aligned to page >> boundary. However the code to compute 'last_page' assumes that there >> are 8 sectors/

Re: [PATCH] dax: Fix last_page check in __bdev_dax_supported()

2019-05-16 Thread Dan Williams
On Wed, May 15, 2019 at 10:55 PM Vaibhav Jain wrote: > > Presently __bdev_dax_supported() checks if first sector of last > page ( last_page ) on the block device is aligned to page > boundary. However the code to compute 'last_page' assumes that there > are 8 sectors/page assuming a 4K page-size.

[PATCH] dax: Fix last_page check in __bdev_dax_supported()

2019-05-15 Thread Vaibhav Jain
Presently __bdev_dax_supported() checks if first sector of last page ( last_page ) on the block device is aligned to page boundary. However the code to compute 'last_page' assumes that there are 8 sectors/page assuming a 4K page-size. This assumption breaks on architectures which use a different p