Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-12-17 Thread Linus Torvalds
Just reviving this thread to see if we could get rid of the OPROFILE kernel code this time.. One option is to just start off with adding a depends on DISABLED on the OPROFILE config option, and see if anybody even notices. But honestly, just removing the entirely might be the better thi

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-11-23 Thread Viresh Kumar
On 20-10-20, 16:31, Viresh Kumar wrote: > From: Arnd Bergmann > > The dcookies stuff is used only with OPROFILE and there is no need to > build it if CONFIG_OPROFILE isn't enabled. Build it depending on > CONFIG_OPROFILE instead of CONFIG_PROFILING. > > Signed-off-by: Arnd Bergmann > [ Viresh:

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-10-28 Thread Arnd Bergmann
On Wed, Oct 28, 2020 at 5:34 PM William Cohen wrote: > > On 10/27/20 12:54 PM, Linus Torvalds wrote: > > On Tue, Oct 27, 2020 at 1:52 AM Christoph Hellwig > > wrote: > >> > >> Is it time to deprecate and eventually remove oprofile while we're at > >> it? > > > > I think it's well past time. > >

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-10-28 Thread William Cohen
On 10/27/20 12:54 PM, Linus Torvalds wrote: > On Tue, Oct 27, 2020 at 1:52 AM Christoph Hellwig wrote: >> >> Is it time to deprecate and eventually remove oprofile while we're at >> it? > > I think it's well past time. > > I think the user-space "oprofile" program doesn't actually use the > lega

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-10-27 Thread Linus Torvalds
On Tue, Oct 27, 2020 at 1:52 AM Christoph Hellwig wrote: > > Is it time to deprecate and eventually remove oprofile while we're at > it? I think it's well past time. I think the user-space "oprofile" program doesn't actually use the legacy kernel code any more, and hasn't for a long time. But I

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-10-27 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig Is it time to deprecate and eventually remove oprofile while we're at it? On Tue, Oct 20, 2020 at 04:31:27PM +0530, Viresh Kumar wrote: > From: Arnd Bergmann > > The dcookies stuff is used only with OPROFILE and there is no need to > build it if CONF

[PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

2020-10-20 Thread Viresh Kumar
From: Arnd Bergmann The dcookies stuff is used only with OPROFILE and there is no need to build it if CONFIG_OPROFILE isn't enabled. Build it depending on CONFIG_OPROFILE instead of CONFIG_PROFILING. Signed-off-by: Arnd Bergmann [ Viresh: Update the name in #endif part ] Signed-off-by: Viresh K