Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-25 Thread Heiko Carstens
On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/block/dcssblk.c

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-25 Thread Heiko Carstens
On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Ameen Ali
avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 ---

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Kees Cook
On Tue, Feb 24, 2015 at 8:41 AM, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali Reviewed-by: Kees Cook -Kees > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Kees Cook
On Tue, Feb 24, 2015 at 7:57 AM, Ameen Ali wrote: > Signed-off-by : Ameen Ali Can you include some text in the commit message body explaining the meaning of the change? (For example 'avoid out-of-bounds-read by checking count before indexing' or something like that?) Reviewed-by: Kees Cook

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Ameen Ali
Signed-off-by : Ameen Ali --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -547,7

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Ameen Ali
Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Kees Cook
On Tue, Feb 24, 2015 at 7:57 AM, Ameen Ali ameenali...@gmail.com wrote: Signed-off-by : Ameen Ali ameenali...@gmail.com Can you include some text in the commit message body explaining the meaning of the change? (For example 'avoid out-of-bounds-read by checking count before indexing' or

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Kees Cook
On Tue, Feb 24, 2015 at 8:41 AM, Ameen Ali ameenali...@gmail.com wrote: avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali ameenali...@gmail.com Reviewed-by: Kees Cook keesc...@chromium.org -Kees --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed,

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-24 Thread Ameen Ali
avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281