Re: [PATCH] debugfs: don't access 4 bytes for a boolean

2015-09-14 Thread Viresh Kumar
On 14-09-15, 17:25, Arnd Bergmann wrote: > I'd say that the argument to debugfs_create_bool() has to match the > access in the functions you are modifying, as well as whatever > gets passed into it by callers. > > By accessing only the first byte, you break all drivers that > call debugfs_create_b

Re: [PATCH] debugfs: don't access 4 bytes for a boolean

2015-09-14 Thread Arnd Bergmann
On Friday 11 September 2015 14:36:06 Viresh Kumar wrote: > > debugfs_create_bool() declares the pointer to be of type u32 *. > Shouldn't that be changed to u8 *? There are many users which are > typecasting the variables to make debugfs API happy I'd say that the argument to debugfs_create_bool(

Re: [PATCH] debugfs: don't access 4 bytes for a boolean

2015-09-11 Thread Greg KH
On Fri, Sep 11, 2015 at 01:18:37PM +0200, Rasmus Villemoes wrote: > On Fri, Sep 11 2015, Viresh Kumar wrote: > > > Long back 'bool' type used to be a typecast to 'int', but that changed > > in v2.6.19. And that is a typecast to _Bool now, which (mostly) takes > > just a byte. Anyway, the bool typ

Re: [PATCH] debugfs: don't access 4 bytes for a boolean

2015-09-11 Thread Rasmus Villemoes
On Fri, Sep 11 2015, Viresh Kumar wrote: > Long back 'bool' type used to be a typecast to 'int', but that changed > in v2.6.19. And that is a typecast to _Bool now, which (mostly) takes > just a byte. Anyway, the bool type in kernel is used to store true/false > or 1/0 only. So, accessing a singl

[PATCH] debugfs: don't access 4 bytes for a boolean

2015-09-11 Thread Viresh Kumar
Long back 'bool' type used to be a typecast to 'int', but that changed in v2.6.19. And that is a typecast to _Bool now, which (mostly) takes just a byte. Anyway, the bool type in kernel is used to store true/false or 1/0 only. So, accessing a single byte should be enough. The problem with current