Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2015-12-17 Thread Vegard Nossum
On 7 April 2014 at 21:18, David Miller wrote: > From: Eric Dumazet > Date: Sun, 06 Apr 2014 14:59:14 -0700 > >> From: Eric Dumazet >> >> dnet_select_source() should make sure dn_ptr is not NULL. >> >> While looking at this decnet code, I believe I found a device >> reference leak, lets fix it as

Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2014-04-08 Thread David Miller
From: Eric Dumazet Date: Mon, 07 Apr 2014 21:51:44 -0700 > On Mon, 2014-04-07 at 15:18 -0400, David Miller wrote: > >> And in the loopback case, it is the decnet stack's responsibility to >> make sure ->dn_ptr is setup properly, else it should fail the module >> load and stack initialization. >>

Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2014-04-07 Thread Eric Dumazet
On Mon, 2014-04-07 at 15:18 -0400, David Miller wrote: > And in the loopback case, it is the decnet stack's responsibility to > make sure ->dn_ptr is setup properly, else it should fail the module > load and stack initialization. > can fix this properly. This was based on Sasha report and my limi

Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2014-04-07 Thread David Miller
From: Eric Dumazet Date: Sun, 06 Apr 2014 14:59:14 -0700 > From: Eric Dumazet > > dnet_select_source() should make sure dn_ptr is not NULL. > > While looking at this decnet code, I believe I found a device > reference leak, lets fix it as well. > > Reported-by: Sasha Levin > Signed-off-by:

[PATCH] decnet: fix possible NULL deref in dnet_select_source()

2014-04-06 Thread Eric Dumazet
From: Eric Dumazet dnet_select_source() should make sure dn_ptr is not NULL. While looking at this decnet code, I believe I found a device reference leak, lets fix it as well. Reported-by: Sasha Levin Signed-off-by: Eric Dumazet --- It seems this bug is very old, no recent change is involved