Re: [PATCH] dell-smbios: fix string overflow

2017-11-09 Thread Pali Rohár
On Wednesday 08 November 2017 13:08:39 Arnd Bergmann wrote: > The new sysfs code overwrites two fixed-length character arrays > that are each one byte shorter than they need to be, to hold > the trailing \0: > > drivers/platform/x86/dell-smbios.c: In function 'build_tokens_sysfs': > drivers/platfo

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Darren Hart
On Wed, Nov 08, 2017 at 01:08:39PM +0100, Arnd Bergmann wrote: > The new sysfs code overwrites two fixed-length character arrays > that are each one byte shorter than they need to be, to hold > the trailing \0: > > drivers/platform/x86/dell-smbios.c: In function 'build_tokens_sysfs': > drivers/pla

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Arnd Bergmann
On Wed, Nov 8, 2017 at 8:03 PM, Andy Shevchenko wrote: > On Wed, Nov 8, 2017 at 8:30 PM, wrote: > > % make W=1 > > which implies some warning, W=2 a lot more. > > [1]: http://patches.linaro.org/cover/107779/ > > [2]: commit bd664f6b3e376a8ef4990f87d08271cc2d01ba9a > Author: Linus Torvalds > Dat

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Arnd Bergmann
On Wed, Nov 8, 2017 at 7:22 PM, sathyanarayanan kuppuswamy wrote: > Hi, > > I recommend using "platform/x86: dell-smbios:" in commit header. Ok, noted. I usually try to follow the lines for each maintainer, but I'm not always keeping track of each one, sorry. > On 11/08/2017 04:08 AM, Arnd Bergm

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Andy Shevchenko
On Wed, Nov 8, 2017 at 8:30 PM, wrote: >> I recommend using "platform/x86: dell-smbios:" in commit header. While we (maintainers) are fixing this manually, it would be better if contributors will do this themselves :-) >> On 11/08/2017 04:08 AM, Arnd Bergmann wrote: >> > The new sysfs code ove

RE: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Mario.Limonciello
x27;Callaghan ; Hans de Goede > ; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] dell-smbios: fix string overflow > > Hi, > > I recommend using "platform/x86: dell-smbios:" in commit header. > > On 11/08/2017 04:08 AM

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread sathyanarayanan kuppuswamy
Hi, I recommend using "platform/x86: dell-smbios:" in commit header. On 11/08/2017 04:08 AM, Arnd Bergmann wrote: The new sysfs code overwrites two fixed-length character arrays that are each one byte shorter than they need to be, to hold the trailing \0: drivers/platform/x86/dell-smbios.c: In

[PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Arnd Bergmann
The new sysfs code overwrites two fixed-length character arrays that are each one byte shorter than they need to be, to hold the trailing \0: drivers/platform/x86/dell-smbios.c: In function 'build_tokens_sysfs': drivers/platform/x86/dell-smbios.c:494:42: error: 'sprintf' writing a terminating nul