Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-06-15 Thread Pali Rohár
On Monday 13 June 2016 19:01:15 Guenter Roeck wrote: > On 06/13/2016 11:26 AM, Pali Rohár wrote: > >Guenter, I think you can take this patch also with Tolga's Tested-by. > > > > The patch on its own doesn't apply. It depends on 'Cache fan-type calls ...'. > Should I take that patch as well ? Ah r

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-06-13 Thread Guenter Roeck
On 06/13/2016 11:26 AM, Pali Rohár wrote: Guenter, I think you can take this patch also with Tolga's Tested-by. The patch on its own doesn't apply. It depends on 'Cache fan-type calls ...'. Should I take that patch as well ? Also, the test feedback was informal. I can not convert it to a form

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-06-13 Thread Pali Rohár
Guenter, I think you can take this patch also with Tolga's Tested-by. On Wednesday 01 June 2016 13:34:47 Tolga Cakir wrote: > Hi Pali, > > thanks for the patch and sorry for the delay! I've checked out > https://git.kernel.org/cgit/linux/kernel/git/groeck/linux-staging.git > /commit/?h=hwmon-stag

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-06-01 Thread Tolga Cakir
Hi Pali, thanks for the patch and sorry for the delay! I've checked out https://git.kernel.org/cgit/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-staging&id=86c050c82dd527b17cf47043831f03646f402a88 and ran it on my Dell M3800. It correctly works for identifying 2 fans, one listed as "P

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-31 Thread Pali Rohár
Tolga, can you test this patch if is working for you correctly? On Saturday 21 May 2016 16:52:46 Pali Rohár wrote: > Some Dell machines (e.g. Dell Precision M3800) have two fans, first with > index=0 and second with index=2. So export also attributes for third fan > device with index=2. > > Repor

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-22 Thread Pali Rohár
On Sunday 22 May 2016 17:11:18 Guenter Roeck wrote: > On 05/21/2016 05:31 PM, Pali Rohár wrote: > > On Sunday 22 May 2016 02:21:46 Guenter Roeck wrote: > >> On 05/21/2016 07:52 AM, Pali Rohár wrote: > >>> Some Dell machines (e.g. Dell Precision M3800) have two fans, > >>> first with index=0 and sec

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-22 Thread Guenter Roeck
On 05/21/2016 05:31 PM, Pali Rohár wrote: On Sunday 22 May 2016 02:21:46 Guenter Roeck wrote: On 05/21/2016 07:52 AM, Pali Rohár wrote: Some Dell machines (e.g. Dell Precision M3800) have two fans, first with index=0 and second with index=2. So export also attributes for third fan device with i

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-21 Thread Pali Rohár
On Sunday 22 May 2016 02:21:46 Guenter Roeck wrote: > On 05/21/2016 07:52 AM, Pali Rohár wrote: > > Some Dell machines (e.g. Dell Precision M3800) have two fans, first > > with index=0 and second with index=2. So export also attributes > > for third fan device with index=2. > > > > Reported-by: To

Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-21 Thread Guenter Roeck
On 05/21/2016 07:52 AM, Pali Rohár wrote: Some Dell machines (e.g. Dell Precision M3800) have two fans, first with index=0 and second with index=2. So export also attributes for third fan device with index=2. Reported-by: Tolga Cakir Signed-off-by: Pali Rohár --- drivers/hwmon/dell-smm-hwmon

[PATCH] dell-smm-hwmon: Detect fan with index=2

2016-05-21 Thread Pali Rohár
Some Dell machines (e.g. Dell Precision M3800) have two fans, first with index=0 and second with index=2. So export also attributes for third fan device with index=2. Reported-by: Tolga Cakir Signed-off-by: Pali Rohár --- drivers/hwmon/dell-smm-hwmon.c | 20 +++- 1 file change