Re: [PATCH] dell_rbu: stop abusing the DMA API

2019-02-07 Thread Darren Hart
On Sat, Feb 02, 2019 at 06:16:59PM +0100, Christoph Hellwig wrote: > On Fri, Feb 01, 2019 at 03:15:59PM -0800, Darren Hart wrote: > > On Tue, Jan 29, 2019 at 08:34:09AM +0100, Christoph Hellwig wrote: > > > For some odd reason dell_rbu actually seems to want the physical and > > > not a bus address

Re: [PATCH] dell_rbu: stop abusing the DMA API

2019-02-02 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 03:15:59PM -0800, Darren Hart wrote: > On Tue, Jan 29, 2019 at 08:34:09AM +0100, Christoph Hellwig wrote: > > For some odd reason dell_rbu actually seems to want the physical and > > not a bus address for the allocated buffer. Lets assume that actually > > is correct given

Re: [PATCH] dell_rbu: stop abusing the DMA API

2019-02-01 Thread Darren Hart
On Tue, Jan 29, 2019 at 08:34:09AM +0100, Christoph Hellwig wrote: > For some odd reason dell_rbu actually seems to want the physical and > not a bus address for the allocated buffer. Lets assume that actually > is correct given that it is BIOS-related and that is a good source > of insanity. In

Re: [PATCH] dell_rbu: stop abusing the DMA API

2019-02-01 Thread Darren Hart
On Fri, Feb 01, 2019 at 12:28:46PM -0600, Stuart Hayes wrote: > > On 1/29/2019 1:34 AM, Christoph Hellwig wrote: > > For some odd reason dell_rbu actually seems to want the physical and > > not a bus address for the allocated buffer. Lets assume that actually > > is correct given that it is BIOS-

Re: [PATCH] dell_rbu: stop abusing the DMA API

2019-02-01 Thread Stuart Hayes
On 1/29/2019 1:34 AM, Christoph Hellwig wrote: > For some odd reason dell_rbu actually seems to want the physical and > not a bus address for the allocated buffer. Lets assume that actually > is correct given that it is BIOS-related and that is a good source > of insanity. In that case we shoul

[PATCH] dell_rbu: stop abusing the DMA API

2019-01-28 Thread Christoph Hellwig
For some odd reason dell_rbu actually seems to want the physical and not a bus address for the allocated buffer. Lets assume that actually is correct given that it is BIOS-related and that is a good source of insanity. In that case we should not use dma_alloc_coherent with a NULL device to alloca