Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Jon Masters
On Thu, 2008-01-03 at 10:12 +1100, Rusty Russell wrote: > Oh, sorry. Jon is now module-init-tools maintainer, and I've cc'd him and > forwarded your original patch. Ta. I was semi-offline last week due to holidays, but already saw the original mail and have another fix for debug sections -

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Rusty Russell
On Wednesday 02 January 2008 22:13:52 Tejun Heo wrote: > Tejun Heo wrote: > > Tejun Heo wrote: > >> Kbuild now generates and installs modules.order along with modules. > >> This patch updates depmod such that it sorts module list according to > >> the file before generating output files. Modules

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Tejun Heo
Tejun Heo wrote: > Tejun Heo wrote: >> Kbuild now generates and installs modules.order along with modules. >> This patch updates depmod such that it sorts module list according to >> the file before generating output files. Modules which aren't on >> modules.order are put after modules which are

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Tejun Heo
Tejun Heo wrote: Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Rusty Russell
On Wednesday 02 January 2008 22:13:52 Tejun Heo wrote: Tejun Heo wrote: Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Jon Masters
On Thu, 2008-01-03 at 10:12 +1100, Rusty Russell wrote: Oh, sorry. Jon is now module-init-tools maintainer, and I've cc'd him and forwarded your original patch. Ta. I was semi-offline last week due to holidays, but already saw the original mail and have another fix for debug sections - will

Re: [PATCH] depmod: sort output according to modules.order, take #2

2007-12-12 Thread Greg KH
On Fri, Dec 07, 2007 at 09:07:57PM +0900, Tejun Heo wrote: > Kbuild now generates and installs modules.order along with modules. > This patch updates depmod such that it sorts module list according to > the file before generating output files. Modules which aren't on > modules.order are put after

Re: [PATCH] depmod: sort output according to modules.order, take #2

2007-12-12 Thread Greg KH
On Fri, Dec 07, 2007 at 09:07:57PM +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after

Re: [PATCH] depmod: sort output according to modules.order, take #2

2007-12-09 Thread Tejun Heo
Tejun Heo wrote: > Kbuild now generates and installs modules.order along with modules. > This patch updates depmod such that it sorts module list according to > the file before generating output files. Modules which aren't on > modules.order are put after modules which are ordered by >

Re: [PATCH] depmod: sort output according to modules.order, take #2

2007-12-09 Thread Tejun Heo
Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered by modules.order.

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Tejun Heo
Jon Masters wrote: > On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: > >> Kbuild now generates and installs modules.order along with modules. >> This patch updates depmod such that it sorts module list according to >> the file before generating output files. Modules which aren't on >>

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Alan Cox
> it doesn't output duplicate entries. Having duplicates is not the right > solution - especially modalias entries that depend entirely upon the > file layout on disk when you run depmod against a kernel. > > Thanks for the ordering patches folks - a good idea! And as it happens just what I need

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Sat, 2007-12-08 at 03:03 -0500, Jon Masters wrote: > On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: > > > Kbuild now generates and installs modules.order along with modules. > > This patch updates depmod such that it sorts module list according to > > the file before generating output

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Thu, 2007-12-06 at 08:28 +0900, Tejun Heo wrote: > As I said, I don't think leaving duplicate lines in a file which will be > installed, distributed and used widely is the RTTD. For what it's worth, I changed the module processing in depmod so that it doesn't output duplicate entries. Having

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: > Kbuild now generates and installs modules.order along with modules. > This patch updates depmod such that it sorts module list according to > the file before generating output files. Modules which aren't on > modules.order are put after

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Sat, 2007-12-08 at 03:03 -0500, Jon Masters wrote: On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files.

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Thu, 2007-12-06 at 08:28 +0900, Tejun Heo wrote: As I said, I don't think leaving duplicate lines in a file which will be installed, distributed and used widely is the RTTD. For what it's worth, I changed the module processing in depmod so that it doesn't output duplicate entries. Having

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Jon Masters
On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Alan Cox
it doesn't output duplicate entries. Having duplicates is not the right solution - especially modalias entries that depend entirely upon the file layout on disk when you run depmod against a kernel. Thanks for the ordering patches folks - a good idea! And as it happens just what I need for

Re: [PATCH] depmod: sort output according to modules.order

2007-12-08 Thread Tejun Heo
Jon Masters wrote: On Tue, 2007-12-04 at 22:55 +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order

[PATCH] depmod: sort output according to modules.order, take #2

2007-12-07 Thread Tejun Heo
Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered by modules.order. This makes modprobe

[PATCH] depmod: sort output according to modules.order, take #2

2007-12-07 Thread Tejun Heo
Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered by modules.order. This makes modprobe

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Sam Ravnborg
> > >>> And this change in Makefile.lib seems bogus: > >>> +# make sure '/' follows subdirs > >>> +subdir-y := $(patsubst %//,%/, $(addsuffix, /,$subdir-y)) > >>> +subdir-m := $(patsubst %//,%/, $(addsuffix, /,$subdir-m)) > >> Some subdir-y|m entries have following / while others

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Tejun Heo
Sam Ravnborg wrote: >> As I said, I don't think leaving duplicate lines in a file which will be >> installed, distributed and used widely is the RTTD. There can be other >> uses of the file. For example, the file can be parsed and modified by >> distro specific module selector. Sure, all of

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Sam Ravnborg
On Thu, Dec 06, 2007 at 08:28:03AM +0900, Tejun Heo wrote: > Sam Ravnborg wrote: > > On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: > >> Tejun Heo wrote: > It would also simplify the kbuild integration if depmod > could read the modules as a space separated list where >

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Sam Ravnborg
On Thu, Dec 06, 2007 at 08:28:03AM +0900, Tejun Heo wrote: Sam Ravnborg wrote: On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: Tejun Heo wrote: It would also simplify the kbuild integration if depmod could read the modules as a space separated list where duplicates are

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Tejun Heo
Sam Ravnborg wrote: As I said, I don't think leaving duplicate lines in a file which will be installed, distributed and used widely is the RTTD. There can be other uses of the file. For example, the file can be parsed and modified by distro specific module selector. Sure, all of them can be

Re: [PATCH] depmod: sort output according to modules.order

2007-12-06 Thread Sam Ravnborg
And this change in Makefile.lib seems bogus: +# make sure '/' follows subdirs +subdir-y := $(patsubst %//,%/, $(addsuffix, /,$subdir-y)) +subdir-m := $(patsubst %//,%/, $(addsuffix, /,$subdir-m)) Some subdir-y|m entries have following / while others don't. subdir-y|m are

Re: [PATCH] depmod: sort output according to modules.order

2007-12-05 Thread Tejun Heo
Sam Ravnborg wrote: > On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: >> Tejun Heo wrote: It would also simplify the kbuild integration if depmod could read the modules as a space separated list where duplicates are allowed. If we do so then the is no reason to

Re: [PATCH] depmod: sort output according to modules.order

2007-12-05 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: > Tejun Heo wrote: > >> It would also simplify the kbuild integration if depmod > >> could read the modules as a space separated list where > >> duplicates are allowed. > >> If we do so then the is no reason to escape to the shell > >> in

Re: [PATCH] depmod: sort output according to modules.order

2007-12-05 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: Tejun Heo wrote: It would also simplify the kbuild integration if depmod could read the modules as a space separated list where duplicates are allowed. If we do so then the is no reason to escape to the shell in Makeilfe.build

Re: [PATCH] depmod: sort output according to modules.order

2007-12-05 Thread Tejun Heo
Sam Ravnborg wrote: On Wed, Dec 05, 2007 at 04:34:30PM +0900, Tejun Heo wrote: Tejun Heo wrote: It would also simplify the kbuild integration if depmod could read the modules as a space separated list where duplicates are allowed. If we do so then the is no reason to escape to the shell in

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Tejun Heo wrote: >> It would also simplify the kbuild integration if depmod >> could read the modules as a space separated list where >> duplicates are allowed. >> If we do so then the is no reason to escape to the shell >> in Makeilfe.build and we do not have to remove duplicates either. > > I'm

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Sam Ravnborg wrote: > Hi Tejun. > On Tue, Dec 04, 2007 at 10:55:48PM +0900, Tejun Heo wrote: >> Kbuild now generates and installs modules.order along with modules. >> This patch updates depmod such that it sorts module list according to >> the file before generating output files. Modules which

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Sam Ravnborg
Hi Tejun. On Tue, Dec 04, 2007 at 10:55:48PM +0900, Tejun Heo wrote: > Kbuild now generates and installs modules.order along with modules. > This patch updates depmod such that it sorts module list according to > the file before generating output files. Modules which aren't on > modules.order are

[PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered by modules.order. This makes modprobe

[PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put after modules which are ordered by modules.order. This makes modprobe

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Sam Ravnborg
Hi Tejun. On Tue, Dec 04, 2007 at 10:55:48PM +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on modules.order are put

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Tejun Heo wrote: It would also simplify the kbuild integration if depmod could read the modules as a space separated list where duplicates are allowed. If we do so then the is no reason to escape to the shell in Makeilfe.build and we do not have to remove duplicates either. I'm no Makefile

Re: [PATCH] depmod: sort output according to modules.order

2007-12-04 Thread Tejun Heo
Sam Ravnborg wrote: Hi Tejun. On Tue, Dec 04, 2007 at 10:55:48PM +0900, Tejun Heo wrote: Kbuild now generates and installs modules.order along with modules. This patch updates depmod such that it sorts module list according to the file before generating output files. Modules which aren't on