Re: [PATCH] dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 Thread David Sterba
On Tue, Jun 05, 2018 at 04:35:07PM +0200, David Sterba wrote: > On Tue, Jun 05, 2018 at 08:22:22AM -0600, Jens Axboe wrote: > > > I fucked up majorly on the bioset/mempool conversion - I forgot to check > > > that > > > everything biosets/mempools were being embedded in was actually being > > > z

Re: [PATCH] dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 Thread Jens Axboe
On 6/5/18 8:35 AM, David Sterba wrote: > On Tue, Jun 05, 2018 at 08:22:22AM -0600, Jens Axboe wrote: >>> I fucked up majorly on the bioset/mempool conversion - I forgot to check >>> that >>> everything biosets/mempools were being embedded in was actually being >>> zeroed on >>> allocation. Device

Re: [PATCH] dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 Thread David Sterba
On Tue, Jun 05, 2018 at 08:22:22AM -0600, Jens Axboe wrote: > > I fucked up majorly on the bioset/mempool conversion - I forgot to check > > that > > everything biosets/mempools were being embedded in was actually being > > zeroed on > > allocation. Device mapper currently explodes, you'll probab

Re: [PATCH] dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 Thread Jens Axboe
On 6/5/18 3:26 AM, Kent Overstreet wrote: > mempool_init()/bioset_init() require that the mempools/biosets be zeroed > first; they probably should not _require_ this, but not allocating those > structs with kzalloc is a fairly nonsensical thing to do (calling > mempool_exit()/bioset_exit() on an un

[PATCH] dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 Thread Kent Overstreet
mempool_init()/bioset_init() require that the mempools/biosets be zeroed first; they probably should not _require_ this, but not allocating those structs with kzalloc is a fairly nonsensical thing to do (calling mempool_exit()/bioset_exit() on an uninitialized mempool/bioset is legal and safe, but