Re: [PATCH] dm-log-userspace: fix memory leak on failure path in dm_ulog_tfr_init()

2014-10-02 Thread Brassow Jonathan
On Oct 1, 2014, at 3:58 PM, Alexey Khoroshilov wrote: > If cn_add_callback() fails in dm_ulog_tfr_init(), it does not > deallocate prealloced memory but calls cn_del_callback(). > It looks like a misprint. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Ale

[PATCH] dm-log-userspace: fix memory leak on failure path in dm_ulog_tfr_init()

2014-10-01 Thread Alexey Khoroshilov
If cn_add_callback() fails in dm_ulog_tfr_init(), it does not deallocate prealloced memory but calls cn_del_callback(). It looks like a misprint. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/md/dm-log-userspace-transfer.c | 2 +- 1