Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Sudip Mukherjee
On Mon, Jun 13, 2016 at 12:59:11PM +0100, Mark Brown wrote: > On Mon, Jun 13, 2016 at 11:51:08AM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 13, 2016 at 10:29:34AM +0100, Mark Brown wrote: > > > > Right, we've got a couple of obscure architectures with no DMA support > > > which are leading to a

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Mark Brown
On Mon, Jun 13, 2016 at 11:51:08AM +0100, Sudip Mukherjee wrote: > On Mon, Jun 13, 2016 at 10:29:34AM +0100, Mark Brown wrote: > > Right, we've got a couple of obscure architectures with no DMA support > > which are leading to a constant stream of patches like this that are > > being triggered by

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Sudip Mukherjee
On Mon, Jun 13, 2016 at 10:29:34AM +0100, Mark Brown wrote: > On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > > > > config SND_SOC_CYGNUS > > > tristate "SoC platform audio for Broadcom Cygnus chips" > > >

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Mark Brown
On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote: > On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > > config SND_SOC_CYGNUS > > tristate "SoC platform audio for Broadcom Cygnus chips" > > depends on ARCH_BCM_CYGNUS || COMPILE_TEST > > + depends on HAS_D

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Christoph Hellwig
On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > Ccing Christoph since his commit introduced bad_dma_ops, and Simran > who wrote that cygnus code. > > I'm thinking that is there to complain loudly when someone is trying > to use dma without HAS_DMA, correct Christoph? Yes. Note

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-13 Thread Sudip Mukherjee
On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > On Sun Jun 12 16, Sudip Mukherjee wrote: > >m32r allmodconfig is failng with errors like: > >ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined! > > > >On checking the code it turns out that struct bad_dma_ops has bee

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-12 Thread Jerry Snitselaar
On Sun Jun 12 16, Sudip Mukherjee wrote: m32r allmodconfig is failng with errors like: ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined! On checking the code it turns out that struct bad_dma_ops has been declared as extern but no one has actually defined struct bad_dma_ops. Lets

[PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-12 Thread Sudip Mukherjee
m32r allmodconfig is failng with errors like: ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined! On checking the code it turns out that struct bad_dma_ops has been declared as extern but no one has actually defined struct bad_dma_ops. Lets remove that and return NULL from get_dma_op