Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 02:38:17PM +0200, Guennadi Liakhovetski wrote: > On Wed, 21 Aug 2013, Jingoo Han wrote: > > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > S

Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-26 Thread Guennadi Liakhovetski
On Wed, 21 Aug 2013, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han This has to be updated on top of current http://git.infra

Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-25 Thread Vinod Koul
On Wed, Aug 21, 2013 at 06:51:56PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Can you pls rebase this as resend. I have applied bunch of sh-dma patch

Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-21 Thread Simon Horman
On Wed, Aug 21, 2013 at 06:45:35PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Acked-by: Simon Horman Vinod, could you take this? > > Signed-off-

[PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-21 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/dma/sh/shdma.c |3 --- drivers/dma/sh/sudmac.c |2 -- 2 files changed, 5 deletions(-)

[PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-21 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/dma/sh/shdma.c |3 --- drivers/dma/sh/sudmac.c |2 -- 2 files changed, 5 deletions(-)