Re: [PATCH] dma-debug: add dumping facility via debugfs

2019-01-22 Thread Joerg Roedel
On Fri, Jan 18, 2019 at 12:35:43PM +0100, Christoph Hellwig wrote: > On Wed, Jan 16, 2019 at 06:10:13PM +, Robin Murphy wrote: > > It's a shame that this is pretty much a duplication of > > debug_dma_dump_mappings(), but there seems no straightforward way to define > > one in terms of the oth

Re: [PATCH] dma-debug: add dumping facility via debugfs

2019-01-18 Thread LABBE Corentin
On Wed, Jan 16, 2019 at 06:10:13PM +, Robin Murphy wrote: > On 16/01/2019 13:44, Corentin Labbe wrote: > > While debugging a DMA mapping leak, I needed to access > > debug_dma_dump_mappings() but easily from user space. > > > > This patch adds a /sys/kernel/debug/dma-api/dump file which contai

Re: [PATCH] dma-debug: add dumping facility via debugfs

2019-01-18 Thread Christoph Hellwig
On Wed, Jan 16, 2019 at 06:10:13PM +, Robin Murphy wrote: > It's a shame that this is pretty much a duplication of > debug_dma_dump_mappings(), but there seems no straightforward way to define > one in terms of the other :/ We could always play some macro magic, but I think that is worse tha

Re: [PATCH] dma-debug: add dumping facility via debugfs

2019-01-16 Thread Robin Murphy
On 16/01/2019 13:44, Corentin Labbe wrote: While debugging a DMA mapping leak, I needed to access debug_dma_dump_mappings() but easily from user space. This patch adds a /sys/kernel/debug/dma-api/dump file which contain all current DMA mapping. Signed-off-by: Corentin Labbe --- kernel/dma/de

[PATCH] dma-debug: add dumping facility via debugfs

2019-01-16 Thread Corentin Labbe
While debugging a DMA mapping leak, I needed to access debug_dma_dump_mappings() but easily from user space. This patch adds a /sys/kernel/debug/dma-api/dump file which contain all current DMA mapping. Signed-off-by: Corentin Labbe --- kernel/dma/debug.c | 47 +++