Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-07 Thread Eric Anholt
Vinod Koul writes: > On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote: >> >> >> - if (ret == DMA_COMPLETE || !txstate) >> >> >> + if (ret == DMA_COMPLETE) >> >> > >> >> > Why do you change this? txstate can be NULL, so no point calculating >> >> > reside >> >> > for those ca

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-07 Thread Vinod Koul
On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote: > >> >> - if (ret == DMA_COMPLETE || !txstate) > >> >> + if (ret == DMA_COMPLETE) > >> > > >> > Why do you change this? txstate can be NULL, so no point calculating > >> > reside > >> > for those cases > >> > >> The point wa

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-06 Thread Eric Anholt
Vinod Koul writes: > On Mon, Jun 06, 2016 at 10:33:18AM -0700, Eric Anholt wrote: >> Vinod Koul writes: >> >> > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: >> >> The tx_status hook is supposed to be safe to call from interrupt >> >> context, but it wouldn't ever return completi

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-06 Thread Vinod Koul
On Mon, Jun 06, 2016 at 10:33:18AM -0700, Eric Anholt wrote: > Vinod Koul writes: > > > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: > >> The tx_status hook is supposed to be safe to call from interrupt > >> context, but it wouldn't ever return completion for the last transfer, >

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-06 Thread Eric Anholt
Vinod Koul writes: > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: >> The tx_status hook is supposed to be safe to call from interrupt >> context, but it wouldn't ever return completion for the last transfer, >> meaning you couldn't poll for DMA completion with interrupts masked. >

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-05 Thread Vinod Koul
On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: > The tx_status hook is supposed to be safe to call from interrupt > context, but it wouldn't ever return completion for the last transfer, > meaning you couldn't poll for DMA completion with interrupts masked. and why is that? > This f

[PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-03 Thread Eric Anholt
The tx_status hook is supposed to be safe to call from interrupt context, but it wouldn't ever return completion for the last transfer, meaning you couldn't poll for DMA completion with interrupts masked. This fixes IRQ handling for bcm2835's DSI1, which requires using the DMA engine to write its