Re: [PATCH] dmaengine: imx-sdma: Add device to device support

2015-07-09 Thread Shengjiu Wang
On Fri, Jul 10, 2015 at 11:52:05AM +0530, Vinod Koul wrote: > On Tue, Jul 07, 2015 at 01:24:22PM +0800, Shengjiu Wang wrote: > > > why not use set_bit(), you are modifying driver memory > > Original driver all use the __set_bit. do you think we need to change > > all the __set_bit to set_bit? And f

Re: [PATCH] dmaengine: imx-sdma: Add device to device support

2015-07-09 Thread Vinod Koul
On Tue, Jul 07, 2015 at 01:24:22PM +0800, Shengjiu Wang wrote: > > why not use set_bit(), you are modifying driver memory > Original driver all use the __set_bit. do you think we need to change > all the __set_bit to set_bit? And from the header file "arch/arm/include/asm > /bitops.h", the set_bit

Re: [PATCH] dmaengine: imx-sdma: Add device to device support

2015-07-07 Thread Shengjiu Wang
On Tue, Jul 07, 2015 at 01:24:20PM +0800, Shengjiu Wang wrote: > Hi vinod > > On Tue, Jul 07, 2015 at 09:50:57AM +0530, Vinod Koul wrote: > > On Tue, Jun 23, 2015 at 04:42:54PM +0800, Shengjiu Wang wrote: > > > +static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) > > > +{ > > >

Re: [PATCH] dmaengine: imx-sdma: Add device to device support

2015-07-06 Thread Shengjiu Wang
Hi vinod On Tue, Jul 07, 2015 at 09:50:57AM +0530, Vinod Koul wrote: > On Tue, Jun 23, 2015 at 04:42:54PM +0800, Shengjiu Wang wrote: > > +static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) > > +{ > > + struct sdma_engine *sdma = sdmac->sdma; > > + > > + int lwml = sdmac->

Re: [PATCH] dmaengine: imx-sdma: Add device to device support

2015-07-06 Thread Vinod Koul
On Tue, Jun 23, 2015 at 04:42:54PM +0800, Shengjiu Wang wrote: > +static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) > +{ > + struct sdma_engine *sdma = sdmac->sdma; > + > + int lwml = sdmac->watermark_level & 0xff; > + int hwml = (sdmac->watermark_level >> 16) & 0x

[PATCH] dmaengine: imx-sdma: Add device to device support

2015-06-23 Thread Shengjiu Wang
This patch adds DEV_TO_DEV support for i.MX SDMA driver to support data transfer between two peripheral FIFOs. The per_2_per script requires two peripheral addresses and two DMA requests, and it need to check the src addr and dst addr is in the SPBA bus space or in the AIPS bus space. Signed-off-b