Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-18 Thread Dan Williams
On Tue, Jun 18, 2013 at 1:01 PM, Andy Shevchenko wrote: > On Tue, Jun 18, 2013 at 10:16 PM, Dan Williams wrote: >> On Tue, Jun 18, 2013 at 10:34 AM, Jubin Mehta wrote: > >>> Would you like to have some changes regarding the configuration >>> process for the module parameters of the dmatest? >> >

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-18 Thread Andy Shevchenko
On Tue, Jun 18, 2013 at 10:16 PM, Dan Williams wrote: > On Tue, Jun 18, 2013 at 10:34 AM, Jubin Mehta wrote: >> Would you like to have some changes regarding the configuration >> process for the module parameters of the dmatest? > > Yes, as a first step I would like to see a clean up of the the

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-18 Thread Dan Williams
On Tue, Jun 18, 2013 at 10:34 AM, Jubin Mehta wrote: > On Mon, Jun 17, 2013 at 02:12:51PM -0700, Dan Williams wrote: >> [ apologies for the resend, gmail defaulted to html ] >> >> On Mon, Jun 17, 2013 at 2:10 PM, Dan Williams wrote: >> >> +Example to perform only MEMCPY and PQ mode tests (0x01 |

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-18 Thread Jubin Mehta
On Mon, Jun 17, 2013 at 11:59:00AM +0300, Andy Shevchenko wrote: > > +PATH = /sys/kernel/debug/dmatest/cap_mask > > +(DEFAULT) echo 0x07 > $PATH // Set Bits 0,1,2 for MEMCPY, XOR and PQ > > + echo 0x01 > $PATH // Set bit 0 to enable MEMCPY > > + echo 0x02 > $PATH // Se

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-18 Thread Jubin Mehta
On Mon, Jun 17, 2013 at 02:12:51PM -0700, Dan Williams wrote: > [ apologies for the resend, gmail defaulted to html ] > > On Mon, Jun 17, 2013 at 2:10 PM, Dan Williams wrote: > >> +Example to perform only MEMCPY and PQ mode tests (0x01 | 0x04 = 0x05): > >> + > >> +% modprobe dmatest > >>

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Andy Shevchenko
On Tue, Jun 18, 2013 at 12:12 AM, Dan Williams wrote: > On Mon, Jun 17, 2013 at 2:10 PM, Dan Williams wrote: >>> +Example to perform only MEMCPY and PQ mode tests (0x01 | 0x04 = 0x05): >>> + >>> +% modprobe dmatest >>> +% echo dma0chan0 > /sys/kernel/debug/dmatest/channel >>> +

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Dan Williams
[ apologies for the resend, gmail defaulted to html ] On Mon, Jun 17, 2013 at 2:10 PM, Dan Williams wrote: >> +Example to perform only MEMCPY and PQ mode tests (0x01 | 0x04 = 0x05): >> + >> +% modprobe dmatest >> +% echo dma0chan0 > /sys/kernel/debug/dmatest/channel >> +%

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Dave Jiang
On 06/17/2013 01:59 AM, Andy Shevchenko wrote: On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta wrote: +++ b/drivers/dma/dmatest.c +/* + * Capability Mask Bits.The bits in the cap_mask denote the masking of + * the hardware capabilities of the dma channel. + * + * DMA_CAP_MEMCPY: Bit 0 for enablin

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Jon Mason
On Mon, Jun 17, 2013 at 11:59:00AM +0300, Andy Shevchenko wrote: > On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta wrote: > > The current dmatest module tests all the hardware capabilities (MEMCPY, XOR > > and PQ) supported by a particular DMA channel and these tests are performed > > concurrently by

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Andy Shevchenko
On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta wrote: > The current dmatest module tests all the hardware capabilities (MEMCPY, XOR > and PQ) supported by a particular DMA channel and these tests are performed > concurrently by default. This patch allows the user to enable or disable the > test perf

[PATCH] dmatest: masking tests for channel capabilities

2013-06-13 Thread Jubin Mehta
The current dmatest module tests all the hardware capabilities (MEMCPY, XOR and PQ) supported by a particular DMA channel and these tests are performed concurrently by default. This patch allows the user to enable or disable the test performed for any particular capability. The mask bits for enabli