Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-06 Thread Jonathan Corbet
On Sat, 03 Sep 2016 00:44:02 +0200 Arnd Bergmann wrote: > On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > > - The guide currently says to pad the structure to a multiple of > > 64-bits. This is not necessary in cases where the structure contains > > no

Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-06 Thread Jonathan Corbet
On Sat, 03 Sep 2016 00:44:02 +0200 Arnd Bergmann wrote: > On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > > - The guide currently says to pad the structure to a multiple of > > 64-bits. This is not necessary in cases where the structure contains > > no 64-bit types.

Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-02 Thread Arnd Bergmann
On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > - The guide currently says to pad the structure to a multiple of > 64-bits. This is not necessary in cases where the structure contains > no 64-bit types. Clarify this concept to avoid unnecessary padding. > - When using __u64

Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-02 Thread Arnd Bergmann
On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > - The guide currently says to pad the structure to a multiple of > 64-bits. This is not necessary in cases where the structure contains > no 64-bit types. Clarify this concept to avoid unnecessary padding. > - When using __u64

[PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-02 Thread Laura Abbott
- The guide currently says to pad the structure to a multiple of 64-bits. This is not necessary in cases where the structure contains no 64-bit types. Clarify this concept to avoid unnecessary padding. - When using __u64 to hold user pointers, blindly trying to do a cast to a void __user *

[PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

2016-09-02 Thread Laura Abbott
- The guide currently says to pad the structure to a multiple of 64-bits. This is not necessary in cases where the structure contains no 64-bit types. Clarify this concept to avoid unnecessary padding. - When using __u64 to hold user pointers, blindly trying to do a cast to a void __user *