Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-03-01 Thread Jonathan Corbet
Yang Shi writes: > When debugging an oom issue, I found the oom_kill counter of memcg is > confusing. At the first glance without checking document, I thought it > just counts for memcg oom, but it turns out it counts both global and > memcg oom. > > The cgroup v2 documents it, but the descripti

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-03-01 Thread Yang Shi
On Mon, Mar 1, 2021 at 4:24 AM Michal Hocko wrote: > > On Fri 26-02-21 11:19:51, Yang Shi wrote: > > On Fri, Feb 26, 2021 at 8:42 AM Yang Shi wrote: > > > > > > On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > > > > > > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > > > > When debugging

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-03-01 Thread Yang Shi
On Mon, Mar 1, 2021 at 4:15 AM Michal Hocko wrote: > > On Fri 26-02-21 08:42:29, Yang Shi wrote: > > On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > > > > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > > > When debugging an oom issue, I found the oom_kill counter of memcg is > > > > con

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-03-01 Thread Michal Hocko
On Fri 26-02-21 11:19:51, Yang Shi wrote: > On Fri, Feb 26, 2021 at 8:42 AM Yang Shi wrote: > > > > On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > > > > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > > > When debugging an oom issue, I found the oom_kill counter of memcg is > > > > conf

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-03-01 Thread Michal Hocko
On Fri 26-02-21 08:42:29, Yang Shi wrote: > On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > > When debugging an oom issue, I found the oom_kill counter of memcg is > > > confusing. At the first glance without checking document, I thought

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-02-26 Thread Yang Shi
On Fri, Feb 26, 2021 at 8:42 AM Yang Shi wrote: > > On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > > When debugging an oom issue, I found the oom_kill counter of memcg is > > > confusing. At the first glance without checking document, I

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-02-26 Thread Yang Shi
On Thu, Feb 25, 2021 at 11:30 PM Michal Hocko wrote: > > On Thu 25-02-21 18:12:54, Yang Shi wrote: > > When debugging an oom issue, I found the oom_kill counter of memcg is > > confusing. At the first glance without checking document, I thought it > > just counts for memcg oom, but it turns out i

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-02-26 Thread Chris Down
Yang Shi writes: When debugging an oom issue, I found the oom_kill counter of memcg is confusing. At the first glance without checking document, I thought it just counts for memcg oom, but it turns out it counts both global and memcg oom. The cgroup v2 documents it, but the description is misse

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-02-26 Thread Shakeel Butt
On Thu, Feb 25, 2021 at 6:12 PM Yang Shi wrote: > > When debugging an oom issue, I found the oom_kill counter of memcg is > confusing. At the first glance without checking document, I thought it > just counts for memcg oom, but it turns out it counts both global and > memcg oom. > > The cgroup v2

Re: [PATCH] doc: memcontrol: add description for oom_kill

2021-02-25 Thread Michal Hocko
On Thu 25-02-21 18:12:54, Yang Shi wrote: > When debugging an oom issue, I found the oom_kill counter of memcg is > confusing. At the first glance without checking document, I thought it > just counts for memcg oom, but it turns out it counts both global and > memcg oom. Yes, this is the case ind

[PATCH] doc: memcontrol: add description for oom_kill

2021-02-25 Thread Yang Shi
When debugging an oom issue, I found the oom_kill counter of memcg is confusing. At the first glance without checking document, I thought it just counts for memcg oom, but it turns out it counts both global and memcg oom. The cgroup v2 documents it, but the description is missed for cgroup v1. S