Re: [PATCH] drbd: correctly handling failed crypto_alloc_hash

2016-02-16 Thread Lars Ellenberg
On Mon, Feb 15, 2016 at 09:26:25PM -0500, Insu Yun wrote: > crypto_alloc_hash returns an error code, not NULL. You are correct, of course. Was broken since its introduction five years ago. Strange though, we have a helper function further down in that file, and other, even much older, call sites

Re: [PATCH] drbd: correctly handling failed crypto_alloc_hash

2016-02-16 Thread Lars Ellenberg
On Mon, Feb 15, 2016 at 09:26:25PM -0500, Insu Yun wrote: > crypto_alloc_hash returns an error code, not NULL. You are correct, of course. Was broken since its introduction five years ago. Strange though, we have a helper function further down in that file, and other, even much older, call sites

[PATCH] drbd: correctly handling failed crypto_alloc_hash

2016-02-15 Thread Insu Yun
crypto_alloc_hash returns an error code, not NULL. Signed-off-by: Insu Yun --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index

[PATCH] drbd: correctly handling failed crypto_alloc_hash

2016-02-15 Thread Insu Yun
crypto_alloc_hash returns an error code, not NULL. Signed-off-by: Insu Yun --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 1957fe8..9063462 100644 ---