Re: Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)

2007-07-07 Thread Robert Hancock
Jeff Garzik wrote: Kuan Luo wrote: @@ -1714,3 +2761,6 @@ module_init(nv_init); module_exit(nv_exit); module_param_named(adma, adma_enabled, bool, 0444); MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)"); +module_param_named(ncq, ncq_enabled, bool, 0444); +MO

Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)

2007-07-07 Thread Jeff Garzik
Kuan Luo wrote: @@ -1714,3 +2761,6 @@ module_init(nv_init); module_exit(nv_exit); module_param_named(adma, adma_enabled, bool, 0444); MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)"); +module_param_named(ncq, ncq_enabled, bool, 0444);

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-20 Thread Zoltan Boszormenyi
Hi, Jeff Garzik írta: Alan Cox wrote: That shouldn't be a problem, libata default DMA mask is 32 bits (which isn't overridden with this controller) and so the block layer will bounce any data being read/written above that point with IOMMU or swiotlb. The comment is a bit unnecessarily scary.

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Robert Hancock
Kuan Luo wrote: Thanks for your comment, see the explaination inline. We'll apply your advice in later patch. ... Please don't duplicate this code in the driver, this is part of libata core in libata-scsi.c. Add an export for these functions if you need to use them in the driver. [kuan]: Th

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Alan Cox
On Fri, 18 May 2007 10:34:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > >> That shouldn't be a problem, libata default DMA mask is 32 bits (which > >> isn't overridden with this controller) and so the block layer will > >> bounce any data being read/written above that point

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Jeff Garzik
Alan Cox wrote: That shouldn't be a problem, libata default DMA mask is 32 bits (which isn't overridden with this controller) and so the block layer will bounce any data being read/written above that point with IOMMU or swiotlb. The comment is a bit unnecessarily scary. Adding a BUG_ON for th

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Alan Cox
> That shouldn't be a problem, libata default DMA mask is 32 bits (which > isn't overridden with this controller) and so the block layer will > bounce any data being read/written above that point with IOMMU or > swiotlb. The comment is a bit unnecessarily scary. Adding a BUG_ON for this would b

RE: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Kuan Luo
n Luo; [EMAIL PROTECTED] Subject: Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61 Peer Chen wrote: > Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA > controller. > > This patch base on sata_nv.c file from kernel 2.6.22-rc1 > >

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Robert Hancock
Zoltan Boszormenyi wrote: Hi, thanks for publishing this. Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. This patch base on sata_nv.c file from kernel 2.6.22-rc1 See attachment for the patch. Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer C

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Robert Hancock
Peer Chen wrote: Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. This patch base on sata_nv.c file from kernel 2.6.22-rc1 See attachment for the patch. Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> Good to finally s

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Jan Engelhardt
On May 17 2007 13:17, Andrew Morton wrote: >> @@ -2115,7 +2115,7 @@ static void nv_fill_sg(struct ata_queued >> WARN_ON(qc->__sg == NULL); >> WARN_ON(qc->n_elem == 0 && qc->pad_len == 0); >> >> -prd = (struct ata_prd*)((u64)pp->prd + ATA_PRD_TBL_SZ*qc->tag); >> +prd = pp->prd +

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Zoltan Boszormenyi
Hi, thanks for publishing this. Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. This patch base on sata_nv.c file from kernel 2.6.22-rc1 See attachment for the patch. Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> ===

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Andrew Morton
On Thu, 17 May 2007 13:12:35 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > The patch generates warnings: > > drivers/ata/sata_nv.c:2118: warning: cast from pointer to integer of > different size > drivers/ata/sata_nv.c:2118: warning: cast to pointer from integer of > different size > > due

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Andrew Morton
On Thu, 17 May 2007 18:15:45 +0800 "Peer Chen" <[EMAIL PROTECTED]> wrote: > Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA > controller. > > This patch base on sata_nv.c file from kernel 2.6.22-rc1 > > See attachment for the patch. > > Signed-off-by: Kuan Luo <[EMAIL PROT

[PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Peer Chen
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. This patch base on sata_nv.c file from kernel 2.6.22-rc1 See attachment for the patch. Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> == See