On Wed, 2014-11-26 at 19:39 -0800, Greg KH wrote:
> Are you going to resend a changed version of this?
Yes, I've been distracted by a few other things, but I suppose I should
do it :-)
Possibly tomorrow. Arnd, are you doing that helper you suggested to get
to the of_node or should I ?
Cheers,
On Thu, Nov 13, 2014 at 12:10:47PM +1100, Benjamin Herrenschmidt wrote:
> So I've been annoyed lately with having a bunch of devices such as i2c
> eeproms (for use by VPDs, server world !) and other bits and pieces that
> I want to be able to identify from userspace, and possibly provide
>
On Thu, Nov 13, 2014 at 12:10:47PM +1100, Benjamin Herrenschmidt wrote:
So I've been annoyed lately with having a bunch of devices such as i2c
eeproms (for use by VPDs, server world !) and other bits and pieces that
I want to be able to identify from userspace, and possibly provide
additional
On Wed, 2014-11-26 at 19:39 -0800, Greg KH wrote:
Are you going to resend a changed version of this?
Yes, I've been distracted by a few other things, but I suppose I should
do it :-)
Possibly tomorrow. Arnd, are you doing that helper you suggested to get
to the of_node or should I ?
Cheers,
On Wed, Nov 19, 2014 at 3:39 PM, Rob Herring wrote:
> On Wed, Nov 19, 2014 at 8:49 AM, Arnd Bergmann wrote:
>> On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
>>> > static inline struct device_node *dev_of_node(struct device *of_node)
>>> > {
>>> > if (!IS_ENABLED(CONFIG_OF))
On Wed, Nov 19, 2014 at 8:49 AM, Arnd Bergmann wrote:
> On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
>> > static inline struct device_node *dev_of_node(struct device *of_node)
>> > {
>> > if (!IS_ENABLED(CONFIG_OF))
>> > return NULL;
>> >
>> > return
On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
> > static inline struct device_node *dev_of_node(struct device *of_node)
> > {
> > if (!IS_ENABLED(CONFIG_OF))
> > return NULL;
> >
> > return dev->of_node;
> > }
> >
> > Adding the IS_ENABLED() in a lot of
On Wed, Nov 19, 2014 at 2:38 AM, Arnd Bergmann wrote:
> On Wednesday 19 November 2014 13:35:44 Benjamin Herrenschmidt wrote:
>> On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
>> > Hi Rob,
>> >
>> > >> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> > >> index 20da3ad..8c7b607
On Wednesday 19 November 2014 13:35:44 Benjamin Herrenschmidt wrote:
> On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
> > Hi Rob,
> >
> > >> diff --git a/drivers/base/core.c b/drivers/base/core.c
> > >> index 20da3ad..8c7b607 100644
> > >> --- a/drivers/base/core.c
> > >> +++
On Wednesday 19 November 2014 13:35:44 Benjamin Herrenschmidt wrote:
On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
Hi Rob,
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 20da3ad..8c7b607 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -493,6
On Wed, Nov 19, 2014 at 2:38 AM, Arnd Bergmann a...@arndb.de wrote:
On Wednesday 19 November 2014 13:35:44 Benjamin Herrenschmidt wrote:
On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
Hi Rob,
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 20da3ad..8c7b607 100644
On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
static inline struct device_node *dev_of_node(struct device *of_node)
{
if (!IS_ENABLED(CONFIG_OF))
return NULL;
return dev-of_node;
}
Adding the IS_ENABLED() in a lot of drivers isn't
On Wed, Nov 19, 2014 at 8:49 AM, Arnd Bergmann a...@arndb.de wrote:
On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
static inline struct device_node *dev_of_node(struct device *of_node)
{
if (!IS_ENABLED(CONFIG_OF))
return NULL;
return
On Wed, Nov 19, 2014 at 3:39 PM, Rob Herring robherri...@gmail.com wrote:
On Wed, Nov 19, 2014 at 8:49 AM, Arnd Bergmann a...@arndb.de wrote:
On Wednesday 19 November 2014 08:45:58 Rob Herring wrote:
static inline struct device_node *dev_of_node(struct device *of_node)
{
if
On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
> Hi Rob,
>
> >> diff --git a/drivers/base/core.c b/drivers/base/core.c
> >> index 20da3ad..8c7b607 100644
> >> --- a/drivers/base/core.c
> >> +++ b/drivers/base/core.c
> >> @@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
On Tue, 2014-11-18 at 10:37 -0600, Rob Herring wrote:
> On Wed, Nov 12, 2014 at 7:10 PM, Benjamin Herrenschmidt
> wrote:
> > So I've been annoyed lately with having a bunch of devices such as i2c
> > eeproms (for use by VPDs, server world !) and other bits and pieces that
> > I want to be able to
Hi Rob,
> struct device doesn't have an of_node member if !CONFIG_OF, so we'll
> need to disable this block in the preprocessor.
Scratch that, I was looking at the wrong header - we do indeed have the
of_node available independently of CONFIG_OF, and this makes the logic a
little cleaner.
Hi Rob,
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index 20da3ad..8c7b607 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
>> goto err_remove_dev_groups;
>> }
On Wed, Nov 12, 2014 at 7:10 PM, Benjamin Herrenschmidt
wrote:
> So I've been annoyed lately with having a bunch of devices such as i2c
> eeproms (for use by VPDs, server world !) and other bits and pieces that
> I want to be able to identify from userspace, and possibly provide
> additional data
On Wed, Nov 12, 2014 at 7:10 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
So I've been annoyed lately with having a bunch of devices such as i2c
eeproms (for use by VPDs, server world !) and other bits and pieces that
I want to be able to identify from userspace, and possibly
Hi Rob,
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 20da3ad..8c7b607 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
goto err_remove_dev_groups;
}
+#ifdef
Hi Rob,
struct device doesn't have an of_node member if !CONFIG_OF, so we'll
need to disable this block in the preprocessor.
Scratch that, I was looking at the wrong header - we do indeed have the
of_node available independently of CONFIG_OF, and this makes the logic a
little cleaner.
Cheers,
On Tue, 2014-11-18 at 10:37 -0600, Rob Herring wrote:
On Wed, Nov 12, 2014 at 7:10 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
So I've been annoyed lately with having a bunch of devices such as i2c
eeproms (for use by VPDs, server world !) and other bits and pieces that
I
On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
Hi Rob,
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 20da3ad..8c7b607 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
So I've been annoyed lately with having a bunch of devices such as i2c
eeproms (for use by VPDs, server world !) and other bits and pieces that
I want to be able to identify from userspace, and possibly provide
additional data about from FW.
Basically, it boils down to correlating the sysfs
So I've been annoyed lately with having a bunch of devices such as i2c
eeproms (for use by VPDs, server world !) and other bits and pieces that
I want to be able to identify from userspace, and possibly provide
additional data about from FW.
Basically, it boils down to correlating the sysfs
26 matches
Mail list logo
