Re: [PATCH] drivers/i2c/i2c-core.c: Fix sparse warning

2015-04-03 Thread Wolfram Sang
> - u8 addr = (msg->addr << 1) | !!(msg->flags & I2C_M_RD); > + u8 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) != 0); I prefer !! as an idiom for "bit to bool". Thanks, Wolfram signature.asc Description: Digital signature

Re: [PATCH] drivers/i2c/i2c-core.c: Fix sparse warning

2015-04-03 Thread Wolfram Sang
- u8 addr = (msg-addr 1) | !!(msg-flags I2C_M_RD); + u8 addr = (msg-addr 1) | ((msg-flags I2C_M_RD) != 0); I prefer !! as an idiom for bit to bool. Thanks, Wolfram signature.asc Description: Digital signature

[PATCH] drivers/i2c/i2c-core.c: Fix sparse warning

2015-04-02 Thread Nickolaus Woodruff
This patch fixes the following sparse warning in drivers/i2c/: CHECK drivers/i2c/i2c-core.c drivers/i2c/i2c-core.c:2353:36: warning: dubious: x | !y Signed-off-by: Nickolaus Woodruff --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drivers/i2c/i2c-core.c: Fix sparse warning

2015-04-02 Thread Nickolaus Woodruff
This patch fixes the following sparse warning in drivers/i2c/: CHECK drivers/i2c/i2c-core.c drivers/i2c/i2c-core.c:2353:36: warning: dubious: x | !y Signed-off-by: Nickolaus Woodruff nickolauswoodr...@gmail.com --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)