On 08/15/2012 10:20 AM, Julia Lawall wrote:
>> devm_request_and_ioremap will already print a error messages on it's own if
>> something goes wrong. So strictly speaking this one is redundant, but I don't
>> think it is necessary to do a resend just for this, maybe you can remove the
>> extra
On 08/15/2012 10:20 AM, Julia Lawall wrote:
devm_request_and_ioremap will already print a error messages on it's own if
something goes wrong. So strictly speaking this one is redundant, but I don't
think it is necessary to do a resend just for this, maybe you can remove the
extra dev_err when
devm_request_and_ioremap will already print a error messages on it's own if
something goes wrong. So strictly speaking this one is redundant, but I don't
think it is necessary to do a resend just for this, maybe you can remove the
extra dev_err when you apply the patch.
Thanks for pointing that
On 08/14/2012 10:32 PM, Jonathan Cameron wrote:
> Lars-Peter,
>
> Are you happy with this updated version? Can't immediately find any response
> from you to it.
>
I think it is ok, you can add my
Reviewed-by: Lars-Peter Clausen .
One minor nitpick though.
> Jonathan
>> From: Julia Lawall
>>
On 08/14/2012 10:32 PM, Jonathan Cameron wrote:
Lars-Peter,
Are you happy with this updated version? Can't immediately find any response
from you to it.
I think it is ok, you can add my
Reviewed-by: Lars-Peter Clausen l...@metafoo.de.
One minor nitpick though.
Jonathan
From: Julia
devm_request_and_ioremap will already print a error messages on it's own if
something goes wrong. So strictly speaking this one is redundant, but I don't
think it is necessary to do a resend just for this, maybe you can remove the
extra dev_err when you apply the patch.
Thanks for pointing that
Lars-Peter,
Are you happy with this updated version? Can't immediately find any response
from you to it.
Jonathan
> From: Julia Lawall
>
> The various devm_ functions allocate memory that is released when a driver
> detaches. This patch uses these functions for data that is allocated in
>
Lars-Peter,
Are you happy with this updated version? Can't immediately find any response
from you to it.
Jonathan
From: Julia Lawall julia.law...@lip6.fr
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is
On 07/31/2012 03:54 PM, Julia Lawall wrote:
>
>
> On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
>
>> Hi,
>>
>> On 07/31/2012 12:09 PM, Julia Lawall wrote:
>>> From: Julia Lawall
>>> @@ -720,20 +698,14 @@ error_ret:
>>> static int __devexit at91_adc_remove(struct platform_device *pdev)
>>> {
On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
> Hi,
>
> On 07/31/2012 12:09 PM, Julia Lawall wrote:
> > From: Julia Lawall
> > @@ -720,20 +698,14 @@ error_ret:
> > static int __devexit at91_adc_remove(struct platform_device *pdev)
> > {
> > struct iio_dev *idev =
From: Julia Lawall
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.
The call to platform_get_resource(pdev,
On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
> Hi,
>
> On 07/31/2012 12:09 PM, Julia Lawall wrote:
> > From: Julia Lawall
> > @@ -720,20 +698,14 @@ error_ret:
> > static int __devexit at91_adc_remove(struct platform_device *pdev)
> > {
> > struct iio_dev *idev =
Hi,
On 07/31/2012 12:09 PM, Julia Lawall wrote:
> From: Julia Lawall
> @@ -720,20 +698,14 @@ error_ret:
> static int __devexit at91_adc_remove(struct platform_device *pdev)
> {
> struct iio_dev *idev = platform_get_drvdata(pdev);
> - struct resource *res = platform_get_resource(pdev,
From: Julia Lawall
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.
The call to platform_get_resource(pdev,
From: Julia Lawall julia.law...@lip6.fr
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.
The call to
Hi,
On 07/31/2012 12:09 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
@@ -720,20 +698,14 @@ error_ret:
static int __devexit at91_adc_remove(struct platform_device *pdev)
{
struct iio_dev *idev = platform_get_drvdata(pdev);
- struct resource *res =
On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
Hi,
On 07/31/2012 12:09 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
@@ -720,20 +698,14 @@ error_ret:
static int __devexit at91_adc_remove(struct platform_device *pdev)
{
struct iio_dev *idev =
From: Julia Lawall julia.law...@lip6.fr
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.
The call to
On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
Hi,
On 07/31/2012 12:09 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
@@ -720,20 +698,14 @@ error_ret:
static int __devexit at91_adc_remove(struct platform_device *pdev)
{
struct iio_dev *idev =
On 07/31/2012 03:54 PM, Julia Lawall wrote:
On Tue, 31 Jul 2012, Lars-Peter Clausen wrote:
Hi,
On 07/31/2012 12:09 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
@@ -720,20 +698,14 @@ error_ret:
static int __devexit at91_adc_remove(struct platform_device *pdev)
{
20 matches
Mail list logo
