Re: [PATCH] drivers/irqchip: Remove function callback casts

2020-05-26 Thread Oscar Carter
Hi Marc, On Sun, May 24, 2020 at 05:16:41PM +0100, Marc Zyngier wrote: > On 2020-05-24 17:06, Oscar Carter wrote: > > > Ok, I will do the changes you suggested and I will resend a new version. > > Later, I will also send a series to clean up the checkpatch warnings and > > errors for the acpi.h he

Re: [PATCH] drivers/irqchip: Remove function callback casts

2020-05-24 Thread Marc Zyngier
On 2020-05-24 17:06, Oscar Carter wrote: Hi Marc, On Sun, May 24, 2020 at 12:46:34PM +0100, Marc Zyngier wrote: On Sun, 24 May 2020 10:09:10 +0200 Oscar Carter wrote: Hi Oscar, Thanks for this. Comments below. > In an effort to enable -Wcast-function-type in the top-level Makefile to > supp

Re: [PATCH] drivers/irqchip: Remove function callback casts

2020-05-24 Thread Oscar Carter
Hi Marc, On Sun, May 24, 2020 at 12:46:34PM +0100, Marc Zyngier wrote: > On Sun, 24 May 2020 10:09:10 +0200 > Oscar Carter wrote: > > Hi Oscar, > > Thanks for this. Comments below. > > > In an effort to enable -Wcast-function-type in the top-level Makefile to > > support Control Flow Integrity bu

Re: [PATCH] drivers/irqchip: Remove function callback casts

2020-05-24 Thread Marc Zyngier
On Sun, 24 May 2020 10:09:10 +0200 Oscar Carter wrote: Hi Oscar, Thanks for this. Comments below. > In an effort to enable -Wcast-function-type in the top-level Makefile to > support Control Flow Integrity builds, remove all the function callback > casts. > > To do this, modify the IRQCHIP_ACP

[PATCH] drivers/irqchip: Remove function callback casts

2020-05-24 Thread Oscar Carter
In an effort to enable -Wcast-function-type in the top-level Makefile to support Control Flow Integrity builds, remove all the function callback casts. To do this, modify the IRQCHIP_ACPI_DECLARE macro initializing the acpi_probe_entry struct directly instead of use the existent macro ACPI_DECLARE