Am 12.02.2007 19:47 schrieb Greg KH:
> +static void gigaset_device_release(struct device *dev)
> +{
> + //FIXME anything to do? cf. platform_device_release()
> +}
> The memory of the platform device itself needs to be freed here,
> otherwise, to do it earlier would cause race
On Sun, Feb 04, 2007 at 01:26:48AM +0100, Tilman Schmidt wrote:
> Am 03.02.2007 17:09 schrieb Greg KH:
> > On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
> >>> +/* dummy to shut up framework warning */
> >>> +static void gigaset_device_release(struct device *dev)
> >>> +{
> >>> +
On Sun, Feb 04, 2007 at 01:26:48AM +0100, Tilman Schmidt wrote:
Am 03.02.2007 17:09 schrieb Greg KH:
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
+/* dummy to shut up framework warning */
+static void gigaset_device_release(struct device *dev)
+{
+ //FIXME anything to
Am 12.02.2007 19:47 schrieb Greg KH:
+static void gigaset_device_release(struct device *dev)
+{
+ //FIXME anything to do? cf. platform_device_release()
+}
The memory of the platform device itself needs to be freed here,
otherwise, to do it earlier would cause race conditions and oopses.
I
This patch adds the line discipline based driver for the Gigaset M101
wireless RS232 adapter. It also improves the documentation a bit.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
Signed-off-by: Hansjoerg Lipp <[EMAIL PROTECTED]>
---
This is the second version, improved thanks to the
This patch adds the line discipline based driver for the Gigaset M101
wireless RS232 adapter. It also improves the documentation a bit.
Signed-off-by: Tilman Schmidt [EMAIL PROTECTED]
Signed-off-by: Hansjoerg Lipp [EMAIL PROTECTED]
---
This is the second version, improved thanks to the Andrew
Andrew Morton schrieb:
> On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>> It's a pointer. Are reads and writes of pointer sized objects
>> guaranteed to be atomic on every platform?
>
> Yup - we make the same assumption about longs in various places.
>
> It's a
Andrew Morton schrieb:
On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote:
It's a pointer. Are reads and writes of pointer sized objects
guaranteed to be atomic on every platform?
Yup - we make the same assumption about longs in various places.
It's a bit strange
On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote:
> Am 04.02.2007 02:56 schrieb Andrew Morton:
> > On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote:
> >
> +spin_lock_irqsave(>cmdlock, flags);
> +cb = cs->cmdbuf;
>
Am 04.02.2007 02:56 schrieb Andrew Morton:
> On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
+ spin_lock_irqsave(>cmdlock, flags);
+ cb = cs->cmdbuf;
+ spin_unlock_irqrestore(>cmdlock, flags);
>>> It is doubtful if the locking here does anything
Am 04.02.2007 02:56 schrieb Andrew Morton:
On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote:
+ spin_lock_irqsave(cs-cmdlock, flags);
+ cb = cs-cmdbuf;
+ spin_unlock_irqrestore(cs-cmdlock, flags);
It is doubtful if the locking here does anything useful.
It
On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote:
Am 04.02.2007 02:56 schrieb Andrew Morton:
On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote:
+spin_lock_irqsave(cs-cmdlock, flags);
+cb = cs-cmdbuf;
+
On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote:
> >> + spin_lock_irqsave(>cmdlock, flags);
> >> + cb = cs->cmdbuf;
> >> + spin_unlock_irqrestore(>cmdlock, flags);
> >
> > It is doubtful if the locking here does anything useful.
>
> It assures atomicity when
Thanks, Andrew, for your review. Some replies:
Am 02.02.2007 02:13 schrieb Andrew Morton:
> On Thu, 1 Feb 2007 22:12:24 +0100
> Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>> +/* Kbuild sometimes doesn't set this */
>> +#ifndef KBUILD_MODNAME
>> +#define KBUILD_MODNAME "asy_gigaset"
>> +#endif
>
Am 03.02.2007 17:09 schrieb Greg KH:
> On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
>>> +/* dummy to shut up framework warning */
>>> +static void gigaset_device_release(struct device *dev)
>>> +{
>>> + //FIXME anything to do? cf. platform_device_release()
>>> +}
>> Ask Greg ;)
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
> > +/* dummy to shut up framework warning */
> > +static void gigaset_device_release(struct device *dev)
> > +{
> > + //FIXME anything to do? cf. platform_device_release()
> > +}
>
> Ask Greg ;)
Oh come on people. Don't provide
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
+/* dummy to shut up framework warning */
+static void gigaset_device_release(struct device *dev)
+{
+ //FIXME anything to do? cf. platform_device_release()
+}
Ask Greg ;)
Oh come on people. Don't provide an empty
Am 03.02.2007 17:09 schrieb Greg KH:
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
+/* dummy to shut up framework warning */
+static void gigaset_device_release(struct device *dev)
+{
+ //FIXME anything to do? cf. platform_device_release()
+}
Ask Greg ;)
Oh come on
Thanks, Andrew, for your review. Some replies:
Am 02.02.2007 02:13 schrieb Andrew Morton:
On Thu, 1 Feb 2007 22:12:24 +0100
Tilman Schmidt [EMAIL PROTECTED] wrote:
+/* Kbuild sometimes doesn't set this */
+#ifndef KBUILD_MODNAME
+#define KBUILD_MODNAME asy_gigaset
+#endif
That's a
On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote:
+ spin_lock_irqsave(cs-cmdlock, flags);
+ cb = cs-cmdbuf;
+ spin_unlock_irqrestore(cs-cmdlock, flags);
It is doubtful if the locking here does anything useful.
It assures atomicity when reading the
On Thu, 1 Feb 2007 22:12:24 +0100
Tilman Schmidt <[EMAIL PROTECTED]> wrote:
> +/* Kbuild sometimes doesn't set this */
> +#ifndef KBUILD_MODNAME
> +#define KBUILD_MODNAME "asy_gigaset"
> +#endif
That's a subtle way of reporting a kbuild bug ;)
What's the story here?
> ---
On Thu, 1 Feb 2007 22:12:24 +0100
Tilman Schmidt [EMAIL PROTECTED] wrote:
+/* Kbuild sometimes doesn't set this */
+#ifndef KBUILD_MODNAME
+#define KBUILD_MODNAME asy_gigaset
+#endif
That's a subtle way of reporting a kbuild bug ;)
What's the story here?
---
22 matches
Mail list logo
