Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-16 Thread Bryan Wu
On Tue, Jun 16, 2015 at 1:23 AM, Jacek Anaszewski wrote: > Hi Paul, > > > On 06/16/2015 12:12 AM, Paul Gortmaker wrote: >> >> This file is built for a bool Kconfig variable, and hence this >> code is either present or absent. It currently can never be >> modular, so using module_init as an alias

Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-16 Thread Jacek Anaszewski
Hi Paul, On 06/16/2015 12:12 AM, Paul Gortmaker wrote: This file is built for a bool Kconfig variable, and hence this code is either present or absent. It currently can never be modular, so using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can

[PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-15 Thread Paul Gortmaker
This file is built for a bool Kconfig variable, and hence this code is either present or absent. It currently can never be modular, so using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the fut