Re: [PATCH] drivers/media/dvb-frontends: Implement probe/remove for stv6110x

Hello, answers, if appropriate, inline! On 26.05.19 11:33, Sean Young wrote: Hi Tobias, On Sun, May 12, 2019 at 04:53:06PM +0200, Tobias Klausmann wrote: Ping, comments for this patch are appreciated! Sorry for not back to you earlier. No problem, thanks for reviewing! Please run scri

Re: [PATCH] drivers/media/dvb-frontends: Implement probe/remove for stv6110x

Hi Tobias, On Sun, May 12, 2019 at 04:53:06PM +0200, Tobias Klausmann wrote: > Ping, > > comments for this patch are appreciated! Sorry for not back to you earlier. Please run script/checkpatch.pl --strict on your patch. There are several cosmetic changes needed. > > Thanks, > > Tobias > >

Re: [PATCH] drivers/media/dvb-frontends: Implement probe/remove for stv6110x

Ping, comments for this patch are appreciated! Thanks, Tobias On 09.05.19 21:51, Tobias Klausmann wrote: Refactor out the common parts of stv6110x_probe() and stv6110x_attach() into separate functions. This provides the needed functionality to use dvb_module_probe() instead of dvb_attach()!