Re: [PATCH] drivers/net/fjes: fix a potential NULL pointer dereference

If I'm looking at this right you are jumping to err_free_netdev without setting the err variable. It must had been set to 0 from the return of fjes_sw_init(). This means we will free the netdev, and return 0. This means probe will not fail and driver's remove function will be run at some

Re: [PATCH] drivers/net/fjes: fix a potential NULL pointer dereference

On Wed, 18 Sep 2019 22:03:15 +0530, Allen Pais wrote: > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. > > Signed-off-by: Allen Pais If I'm looking at this right you are jumping to err_free_netdev without setting the err variable. It must

[PATCH] drivers/net/fjes: fix a potential NULL pointer dereference

alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais --- drivers/net/fjes/fjes_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index