Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-06-08 Thread Samuel Ortiz
Hi Valentin, On Tue, Apr 28, 2015 at 11:08:47AM +0200, Valentin Rothberg wrote: > The CPP identifier 'DEBUG' is not used in the source code of nfc at all, > so we can safely remove setting it in both Makefiles. > > Signed-off-by: Valentin Rothberg > --- > I detected this issue with ./scripts/che

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-04-29 Thread Paul Bolle
On Wed, 2015-04-29 at 10:45 +0200, Valentin Rothberg wrote: > Thanks, I was not aware of it at all. I read the code and it seems > that if neither DYNAMIC_DEBUG nor DEBUG is defined, pr_debug() does > nothing more than to return 0. > > I am not sure what to do in this case. Somehow it seems reas

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-04-29 Thread Valentin Rothberg
Hi Paul, On Wed, Apr 29, 2015 at 10:27 AM, Paul Bolle wrote: > [Added Joe.] > > On Tue, 2015-04-28 at 11:08 +0200, Valentin Rothberg wrote: >> The CPP identifier 'DEBUG' is not used in the source code of nfc at all, >> so we can safely remove setting it in both Makefiles. >> >> Signed-off-by: Val

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-04-29 Thread Paul Bolle
[Added Joe.] On Tue, 2015-04-28 at 11:08 +0200, Valentin Rothberg wrote: > The CPP identifier 'DEBUG' is not used in the source code of nfc at all, > so we can safely remove setting it in both Makefiles. > > Signed-off-by: Valentin Rothberg > --- > I detected this issue with ./scripts/checkkconf

[PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-04-28 Thread Valentin Rothberg
The CPP identifier 'DEBUG' is not used in the source code of nfc at all, so we can safely remove setting it in both Makefiles. Signed-off-by: Valentin Rothberg --- I detected this issue with ./scripts/checkkconfigsymbols.py since CONFIG_NFC_DEBUG is not defined in Kconfig. --- drivers/nfc/Makefi